Operation-level timeout about aiosmtplib

[cole]

Thanks for reporting!

Current expected behaviour is that two timeout kwargs set the instance value– __init__ and connect. Other methods should not persist the timeout. This might not be documented correctly.

I agree this doesn't work well for the case where the connect timeout should be different than the default.

I'll have a look but I think the suggested change is reasonable, probably I can proceed with that 👍

[wombatonfire]

Hi Cole, thanks for the great lib!

I'm happy to contribute and implement this change. I haven't checked other methods, only connect. Let me see how they handle timeout without persisting it, and I'll create a pull request.

[wombatonfire]

Ok, so SMTP.timeout is updated by _update_settings_from_kwargs() in connect() and starttls(). I changed those methods to handle passed timeout value similar to how execute_command() does.

This required changing the signature of _create_connection() and adding the timeout argument, but I suppose it shouldn't be an issue, since it's a private method.

The timeout argument was also removed from _update_settings_from_kwargs() as it's not supposed to be updated there anymore.

If this makes sense, I suppose some tests should be added?

[wombatonfire]

Didn't realize the pull request was created in the wrong repository/branch.