Comments (6)
A guide has been added, and, it seems pretty streamlined for new users. Nonetheless, we don't target GNU Make, and some Make implementations that Concord builds under (e.g. SVR3 Make) can't be expected to have some variables predefined. Conditional assignment is flakey on some Makes, and, systems with non-GCC compilers won't take the conditionally-assigned CFLAGS
anyways -- we try to bend over backwards to make that Makefile work on any make implementation out there on a POSIX.2 system with a C99 compiler, so, there's a fair bit of weirdness in there.
If you run into any more issues, feel free to give us a shout -- good luck on your project!
from concord.
The current procedure is to enter the gencodecs directory and invoke make
with $(CC)
overriden on the command line or in the Makefile, however, this does NOT properly cross-compile. Let me fix that and make a few notes on that!
from concord.
Okay, it should be fixed. I made a note in the README that explains how to do it -- I tried to make it as simple as possible. Feel free to drop another comment if you've got any more feedback, and thanks for the report!
from concord.
Hmm, well cross-compiling works perfectly well for me if I patch that Makefile to use a non-CC
variable and inherit CC
from the main Makefile that calls into it instead. I feel like having a separate step for gencodecs is just pointless complexity.
from concord.
Well, to be fair, there is a reason the architecture is the way it is -- gencodecs is not a component that is exclusive to Concord, and was designed to be somewhat generic. Regardless, the change has been made and it should be pretty easy for 99.99% of users to roll with.
from concord.
gencodecs […] was designed to be somewhat generic
I think that's even more of an argument in favour of not needlessly overriding these implicit Make variables then, or changing something about the way these are assigned at least. With GNU Make, CC
and CPP
are already implicitly defined and have reasonably-likely fallback values. The file already uses conditional variable assignment for CFLAGS
, so the same could be done for those two if you really want to be sure that it has some assignment.
But yes, feel free to close as the original issue has been resolved. Just trying to cut down the patching I need to do so everything behaves as it should.
from concord.
Related Issues (20)
- Support HTTP 1.1
- Add guides to Concord HOT 11
- Websocket payloads taking long to be sent HOT 3
- Chash (used on Concord) possible not working on FreeBSD HOT 1
- Segfault due to race conditions in discord_cleanup when called from another thread HOT 7
- Incomplete presence info and guild members HOT 15
- discord_modify_channel rtc_region issue HOT 2
- Insufficient buffer size causes truncation, malformed request
- Signal Safety in concord-once.h HOT 2
- Make Error - Windows, Cygwin HOT 3
- WebSocket upgrade fails with 'server didn't accept the websocket upgrade' error when using an HTTP proxy HOT 1
- Raspberry Pi (64-bit) library setup problem HOT 3
- Easy server member permission checking HOT 1
- User-defined memory functions HOT 4
- Ship a pkg-config file
- messages: Support silent flag HOT 12
- `DISCORD_MAX_MESSAGE_LEN` has the wrong value HOT 3
- Enums to pointer to enums
- Pass additional data to callbacks HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concord.