Coder Social home page Coder Social logo

Comments (3)

zmeir avatar zmeir commented on May 15, 2024 1

Oh my bad, I thought it worked the same as its equivalent REST API which does support this functionality:
https://docs.github.com/en/rest/pulls/reviews?apiVersion=2022-11-28#create-a-review-for-a-pull-request

from pr-agent.

hussam789 avatar hussam789 commented on May 15, 2024

pr.create_review is made for the comments on the entire PR and it doesn't have position/line argument:
https://github.com/PyGithub/PyGithub/blob/294c0cc9c5a0a5f127dd12ab2cc7ac7ca9c3e59c/github/PullRequest.pyi#L54

It's usually used like this:

self.pull.create_review(event="APPROVE")

I don't think PyGithub has an API to batch these comments together yet

from pr-agent.

hussam789 avatar hussam789 commented on May 15, 2024

Thanks for pointing this out, maybe PyGithub will support it in the future, we can open an issue there.
You are right, sending comments in a batch is preferred

from pr-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.