Comments (7)
I would like to add perhaps it could be an option. I prefer to re-request review personally.
from pr-agent.
i believe #215 is right for this purpose correct @tjwp ?
from pr-agent.
This would need some additional changes to handle incremental. It would need to look for a synchronize
action on a PR and trigger an incremental review (only available by arg currently). It should probably be an additional setting.
from pr-agent.
i am not sure you would like review to be run automatically every new commit. it can flood the git with a lot(!) of messages.
my suggestion - use it manually, when needed.
from pr-agent.
This can almost be accomplished already. synchronize
can be added to the handle_pr_actions and improve -i
can be added to pr-commands. The only thing missing is being able to do it differently the first time vs. every time.
If the config was separated out to allow you to specify specific commands for specific actions we'd have that flexibility. Maybe something to consider @mrT23 .
from pr-agent.
Technically its possible, i agree.
However, optional features still need to be viable.
In practice, even as an option, would you really want 10-20 long review feedback messages in a single PR ?
we tried this way (Triggering on every commit) when starting developing pr-agent, and it was awful
I think a better option is to enable to update the initial review message after every commit, so review feedback will always be up-to-date.
but I am not sure. open for feedback
from pr-agent.
@mrT23 I would expect it to update existing, yes.
from pr-agent.
Related Issues (20)
- Add persistent_comment option for `/describe` HOT 6
- URL
- Failed to review PR: name 'is_valid_file' is not defined HOT 1
- No need to check OPENAI_KEY when using non OpenAI models HOT 1
- [GitHub Actions] How do I configure using `.pr_agent.toml` file? HOT 5
- Changelog commit includes option to start with "[skip ci]" > "[skip ci] Update CHANGELOG.md" HOT 4
- Can't log in to IntelliJ IDEA
- Can we use pr-agent with custom llm provider? HOT 7
- 'summarize_mode' is undefined HOT 5
- gpt-3.5-turbo context window is 16k HOT 3
- gitlab_provider asign personal_access_token to oauth_token may not work? HOT 5
- Clarifications on Azure Open AI configuration HOT 3
- /review broke - docker:latest HOT 3
- Replace 👀 with ❤️ when response is completed HOT 2
- Have `/config` print the working config as well as all the options HOT 1
- Do we take any benchmarks between different LLMs? HOT 1
- Add label base on pull request description. HOT 6
- PR-Agent Chrome Extension: AWS CodeCommit HOT 1
- Azure DevOps output for suggestions is not aligned correctly in latest release HOT 2
- Update tiktoken to use gpt-4o HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pr-agent.