Coder Social home page Coder Social logo

Comments (7)

bperreault avatar bperreault commented on May 15, 2024

I would like to add perhaps it could be an option. I prefer to re-request review personally.

from pr-agent.

idavidov avatar idavidov commented on May 15, 2024

i believe #215 is right for this purpose correct @tjwp ?

from pr-agent.

tjwp avatar tjwp commented on May 15, 2024

This would need some additional changes to handle incremental. It would need to look for a synchronize action on a PR and trigger an incremental review (only available by arg currently). It should probably be an additional setting.

from pr-agent.

mrT23 avatar mrT23 commented on May 15, 2024

i am not sure you would like review to be run automatically every new commit. it can flood the git with a lot(!) of messages.

my suggestion - use it manually, when needed.

from pr-agent.

esauser avatar esauser commented on May 15, 2024

This can almost be accomplished already. synchronize can be added to the handle_pr_actions and improve -i can be added to pr-commands. The only thing missing is being able to do it differently the first time vs. every time.

If the config was separated out to allow you to specify specific commands for specific actions we'd have that flexibility. Maybe something to consider @mrT23 .

from pr-agent.

mrT23 avatar mrT23 commented on May 15, 2024

Technically its possible, i agree.

However, optional features still need to be viable.
In practice, even as an option, would you really want 10-20 long review feedback messages in a single PR ?
we tried this way (Triggering on every commit) when starting developing pr-agent, and it was awful

I think a better option is to enable to update the initial review message after every commit, so review feedback will always be up-to-date.

but I am not sure. open for feedback

from pr-agent.

esauser avatar esauser commented on May 15, 2024

@mrT23 I would expect it to update existing, yes.

from pr-agent.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.