Add dialog callback function not working about firetext

[ferndot]

It broke again?

[HR]

There is an additional problem in general, that is that the html is parsed even in the description of the document at the welcome screen, which it shouldn't.

[ferndot]

That was intended, the html in the description messed things up.

[HR]

To parse html in the description?

[ferndot]

Yes, see 17f7e74.

We don't want headers, images, tables, and things in the description.

[HR]

You should parse it but remove any styles, what do you think?

[ferndot]

Then what would be the point?

[HR]

The styling could ruin the app, what if someone sets font to larger or tries to parse any other styling that would interfere in the UI?

[ferndot]

Oh, I think we are misunderstanding each other :D

Currently, it is just printing the text content of the file. I don't think we should change this as the description is only supposed to be text anyway, and it could cause a security vulnerability like in #7.

[HR]

Go in app and type this for example: <h1 style="color:red; font-size: 2em;">hi<h1> and you see the styling being applied that ruins the UI

[ferndot]

Oh, let me see something...

[ferndot]

That was easy to fix: a88255f.

Don't worry if it looks hacky, it will work!

[ferndot]

...this bug...

[HR]

1 day to go...

[ferndot]

oh dear!

[ferndot]

I was right!

[ferndot]

Almost have this fixed :)

[logan-r]

Great!

[ferndot]

We can ship after I improve the first load experience with one more commit!

[HR]

wait I have to add one more thing as well before we ship!

[ferndot]

Yes, what is it?

[HR]

done, added custom title font (logo)

[ferndot]

oh :D

[HR]

hooray, we're done.

[HR]

should I upload it to mozilla?

[ferndot]

I am getting one of the gaia devs to test it in a few mins, so please don't upload yet.

[HR]

ok, and I test it in the validator: https://marketplace.firefox.com/developers/validator

[HR]

1 warning, 0 errors: https://marketplace.firefox.com/developers/upload/f751bdebc99a43a29b56f8720b119284

[ferndot]

I am packaging it in a special way to avoid that issue. Don't delete that file. It keeps other system files from being stored in the repo.

[HR]

Oh, I deleted the hidden file, now its fine: 0 warning, 0 errors: https://marketplace.firefox.com/developers/upload/4d1bbfc6eaeb44a5b5c5804cd8141d57

[HR]

I didn't delete any file from repo, I deleted from .zip after I downloaded a copy:)

[ferndot]

Phew :)

[HR]

have gaia devs tested it yet?

[ferndot]

He said that he would do it in a bit. We are on ircs://moznet/gaia.

[ferndot]

I uploaded it to the marketplace! @HRanDEV, can you set up redirects for our [email protected] email so that it will send me copies of messages received?

[logan-r]

@joshua-s Awesome! But... I don't see firetext in the marketplace. 😦 Is there some sort of verification process before it gets published?

@HRanDEV Could you set up an email redirect for me too?

[HR]

here is the URL: https://marketplace.firefox.com/app/firetext/

[HR]

Ok, I will

[HR]

I need your confirmation codes(send via email) to forward emails.

[logan-r]

@HRanDEV Thanks for the link and I just submitted my confirmation code!

[ferndot]

@HRanDEV I sent the code!