Dotfiles fails: /bin/sh: 2: Bad substitution about modules

[matifali]

Hi @jaulz, this module uses coder dotfiles to setup/install the dotfiles, which requires the presence of a script. It looks like there is no script in your dotfiles repo.
Please see this for more details: https://coder.com/docs/v2/latest/dotfiles#setup-script-support

[jaulz]

@matifali thanks for the feedback! In fact, I checked the documentation but it sounded to me that the script is optional is and if it doesn't exist the configuration files are copied only.

[matifali]

@jaulz can you manually run coder dotfiles <your-dotfiles-repo> from within your workspace and see if it works? This will help us identify if the issue is with the module or the coder dotfiles command.

[jaulz]

@matifali it's also not really working:

Maybe because there is already other stuff in the folder (e.g. code-server from other module)?

[matifali]

The issue is with coder dotfiles and not the module, so I moved it here to this repo.

[mafredri]

@matifali to me this looks problematic:

modules/dotfiles/main.tf

Line 31 in f8faea1

if [ -n "$${DOTFILES_URI// }" ]; then

We should make sure this check is /bin/sh compatible, if we need it at all. That seems to be the source of the bad substitution error.

Perhaps that check is better done in terraform? Or perhaps the trim spaces and then just check for emptyness in the script. Or not create the script if empty.