Coder Social home page Coder Social logo

Comments (10)

Dracks avatar Dracks commented on May 19, 2024 1

more info here:
http://angelicgarbage.com/posts/how-to-deploy-a-godot-4-game-to-github-pages/

I will try first in my fork of the project, and I will try to see if we can keep some kind of history of the last 7 builds, or similar.

from codename-recon.

HunterNN avatar HunterNN commented on May 19, 2024 1

There is also commented code in the export workflow, which may be helpful. If not, you can go ahead and remove it.:

# - name: Install rsync 📚
# run: |
# apt-get update && apt-get install -y rsync
# - name: Deploy to GitHub Pages 🚀
# uses: JamesIves/github-pages-deploy-action@releases/v4
# with:
# branch: gh-pages # The branch the action should deploy to.
# folder: build/web # The folder the action should deploy.

from codename-recon.

Dracks avatar Dracks commented on May 19, 2024 1

I did my fightings with cors and this stuff..

We can also try with cors, configuring the server that the domain of the client is a valid cors domain, it should work.

Maybe we can do a call and take a look

from codename-recon.

HunterNN avatar HunterNN commented on May 19, 2024 1

FYI: https://github.com/JamesIves/github-pages-deploy-action

from codename-recon.

Darkbladecr avatar Darkbladecr commented on May 19, 2024 1

Yes it is probably a CORS restriction by Nakama, there should definitely be a way for us to configure this. On first pass through the documentation, I don't see any config/restrictions for this. Will take a closer look later.

from codename-recon.

Dracks avatar Dracks commented on May 19, 2024

yeah, publishing into pages usually is straight forward... The most complex part, is having the history.

Also, one more thing, the exports that you have are only for releases/new-versions, right? I think the export to pages will make sense to be the nightly build

from codename-recon.

HunterNN avatar HunterNN commented on May 19, 2024

Currently, the files are stored as artifacts, making them resemble nightly builds for me. The release one, however, should be generated using tags. Do you think there's anything missing for nightly builds?

What do you mean by "history"? Are you referring to the change log?

from codename-recon.

HunterNN avatar HunterNN commented on May 19, 2024

Based on this #22 (comment)
When hosting the web export on a local computer or on Itch.io, it appears that the game is unable to connect to Nakama.

I suspect the issue may be due to the same-origin policy:
https://developer.mozilla.org/en-US/docs/Web/Security/Same-origin_policy

It appears that we can resolve this by hosting Nakama and the page under the same domain. However, I am not completely certain. @Darkbladecr Do you know if this is indeed the case?

from codename-recon.

Dracks avatar Dracks commented on May 19, 2024

Yes it is probably a CORS restriction by Nakama, there should definitely be a way for us to configure this. On first pass through the documentation, I don't see any config/restrictions for this. Will take a closer look later.

If I remember correctly, also different subdomain triger the cors, right? otherwise, we can use the custom domain of the github pages (I never worked with github pages before)

I also look for cors configuration in Nakama, and I didn't find it, but I think the easy will be to put an nginx in the front, Also, with that, we can handle to put nakama in a subpath of the same public domain of the game. (Nginx serving the game, and nakama for the same domain)

from codename-recon.

Dracks avatar Dracks commented on May 19, 2024

fixed here: #28

from codename-recon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.