.refresh() Doesn't update gutter height? about codemirror5

[marijnh]

Hi Chiel,

Are you working with the current git HEAD? Commit ef83a91 fixed something related to this, and if I now open one of the demo pages, and set (from the script console) the height of the editor, the gutter is indeed off, but calling .refresh() does properly fix this.

Best,
Marijn

[chiel]

Hi Marijn,

I made a point to pull in the latest version of CodeMirror2 before "whining" about it here, so yep, I do have that fix.

If .refresh() is supposed to work as I thought, then the only thing I can think of, is the fact that I changed the style of the .CodeMirror class by using height: 100%;, since it's inside of a wrapper, that resizes with the rest of the layout.

This shouldn't really cause any issues as far as I know, but hey, it might be contributing? In what way do you assess the height of the codemirror instance? I made a little hack for this, for now, but it's hardly ideal. Basically every time the window (which means also the editor-wrapper) I set the height of the gutter to "", and the min-height to 100%. That way it's always at least 100% of the codemirror instance, yet it'll still stretch past this.

Best,
Chiel

[marijnh]

Someone in the google group provided me with a test case for this. db0a7e6 should solve it. If it doesn't reopen.

[chiel]

Awesome, this does the trick perfectly! Thanks a lot for being so fast with all this. CodeMirror is a delight to work with. At the moment it seems to be really slow in Chrome, though. But I'll make another ticket about that if it remains an issue.

Cheers!