Coder Social home page Coder Social logo

Comments (5)

sv3tli0 avatar sv3tli0 commented on September 2, 2024

Come on.. you report issue on dev version of something which doesn't have Alpha version..

from codeigniter4.

lonnieezell avatar lonnieezell commented on September 2, 2024

To be honest - I've been waiting until a final PHP 7 is released to build a proper box. My current box doesn't have debug installed so haven't had a chance to test that yet. It will all happen in time. :)

from codeigniter4.

kenjis avatar kenjis commented on September 2, 2024

This error is because of processUncoveredFilesFromWhitelist="true", which is noted:

Please note that the loading of sourcecode files that is performed when processUncoveredFilesFromWhitelist="true" is set can cause problems when a sourcecode file contains code outside the scope of a class or function, for instance.
https://phpunit.de/manual/current/en/code-coverage-analysis.html#code-coverage-analysis.whitelisting-files

from codeigniter4.

kenjis avatar kenjis commented on September 2, 2024

I don't think we need processUncoveredFilesFromWhitelist="true".
See http://stackoverflow.com/questions/29041254/phpunit-coverage-what-is-the-difference-between-adduncoveredfilesfromwhitelist

We can get Code Coverage with the following diff:

--- a/phpunit.xml
+++ b/phpunit.xml
@@ -15,7 +15,7 @@
     </testsuites>

     <filter>
-        <whitelist processUncoveredFilesFromWhitelist="true">
+        <whitelist addUncoveredFilesFromWhitelist="true">
             <directory suffix=".php">./system</directory>
         </whitelist>
     </filter>

The default value of addUncoveredFilesFromWhitelist is true. So it is the same as just <whitelist>.

from codeigniter4.

lonnieezell avatar lonnieezell commented on September 2, 2024

Actually, that stackoverflow comment makes it sound like leaving it to the default processUncoveredFilesFromWhitelist=false is a faster method that is just as accurate when the answer is 0. So, it seems we can just do the whitelist tag without any attributes here.

Thanks. Will push a change.

from codeigniter4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.