Coder Social home page Coder Social logo

Enforcing signing about codeigniter4 HOT 5 CLOSED

codeigniter4 avatar codeigniter4 commented on July 28, 2024
Enforcing signing

from codeigniter4.

Comments (5)

lonnieezell avatar lonnieezell commented on July 28, 2024

That would mean I need to get in that habit, too, wouldn't it? :)

I believe the original intent of that requirement was to sign-off that they were giving their original code and making it available under what license EllisLab had it under. Since we're not saying that, is there a need for signing off? Seems like another barrier for contributions that doesn't add anything for us right now.

from codeigniter4.

jim-parry avatar jim-parry commented on July 28, 2024

It is intended to prove the provenance of contributed code.
I have a PR in progress to test the commiting with a GPG key.

from codeigniter4.

jim-parry avatar jim-parry commented on July 28, 2024

I think at a minimum we need to enforce reasonable descriptions, all the orhter stuff in the contributing guideline (test if needed, docs if needed, user guide if needed), and at a minimum a "signoff", even if it isn't GPG. We have had a few sloppy commits over the last day or two, adn I think we need to nip that.

from codeigniter4.

jim-parry avatar jim-parry commented on July 28, 2024

The original intent, when I talked to Ellis back when, was both to make sure EllisLab could use code, as well as to establish provenance going forward with version 3.
Quoting narf.. "We do formally require this, but people being people made it an afterthought even for us."

from codeigniter4.

lonnieezell avatar lonnieezell commented on July 28, 2024

I think at a minimum we need to enforce reasonable descriptions, all the orhter stuff in the contributing guideline (test if needed, docs if needed, user guide if needed),

Couldn't agree more.

and at a minimum a "signoff", even if it isn't GPG.

Unconvinced it's necessary since every commit is attached to an account which is recorded during the commit, so ownership/provenance is already recorded.

from codeigniter4.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.