Comments (5)
That would mean I need to get in that habit, too, wouldn't it? :)
I believe the original intent of that requirement was to sign-off that they were giving their original code and making it available under what license EllisLab had it under. Since we're not saying that, is there a need for signing off? Seems like another barrier for contributions that doesn't add anything for us right now.
from codeigniter4.
It is intended to prove the provenance of contributed code.
I have a PR in progress to test the commiting with a GPG key.
from codeigniter4.
I think at a minimum we need to enforce reasonable descriptions, all the orhter stuff in the contributing guideline (test if needed, docs if needed, user guide if needed), and at a minimum a "signoff", even if it isn't GPG. We have had a few sloppy commits over the last day or two, adn I think we need to nip that.
from codeigniter4.
The original intent, when I talked to Ellis back when, was both to make sure EllisLab could use code, as well as to establish provenance going forward with version 3.
Quoting narf.. "We do formally require this, but people being people made it an afterthought even for us."
from codeigniter4.
I think at a minimum we need to enforce reasonable descriptions, all the orhter stuff in the contributing guideline (test if needed, docs if needed, user guide if needed),
Couldn't agree more.
and at a minimum a "signoff", even if it isn't GPG.
Unconvinced it's necessary since every commit is attached to an account which is recorded during the commit, so ownership/provenance is already recorded.
from codeigniter4.
Related Issues (20)
- Bug: `migrate:rollback -b` impossible due to TypeError HOT 4
- Bug: [Validation] if_exist is not working as intended with arrays HOT 1
- Bug: spark routes doesn't work with `(.+)` HOT 2
- Bug: nested $routes->group() with same filter name doesn't work as exepcted HOT 14
- Bug: system/Database/OCI8/Connection.php fails to parse valid DSN HOT 10
- Bug: When Install fresh codeigniter 4 Project I am getting "does not comply with psr-4 autoloading standard" HOT 1
- Bug(OCI8): $validDSNs regex for Oracle service names should support periods HOT 1
- Bug: [QueryBuilder] select() TypeError: trim(): Argument #1 ($string) must be of type string, CodeIgniter\Database\RawSql given HOT 4
- Validation `valid_date` does not work with time HOT 2
- Bug: Auto Routing (Legacy) does not behave like legacy anymore. HOT 9
- Bug: validation level dont work as expected HOT 6
- Bug: Class 'file' not found in SYSTEMPATH\Config\Services.php on line 686. HOT 5
- Bug: `spark phpini:check` TypeError HOT 4
- Bug: ENVIRONMENT is not updated when changed via .ENV ( 4.5.3) HOT 5
- [Feat] Routing: Support to PHP Attributes HOT 4
- Bug: routes not work in ci 4.3.5 HOT 2
- Bug: debug bar content not show with daisyUI ver 4.12.10 HOT 4
- Bug: TypeError in pg_ping() HOT 7
- Add to $filters except urls like in globals HOT 1
- Bug: Module/Config/Registrar.php cause infinite loop in codeigniter4\framework\system\Autoloader\FileLocator.php on line 226
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from codeigniter4.