Coder Social home page Coder Social logo

Comments (6)

mchung avatar mchung commented on August 11, 2024

Due to a change in the way routing is handled in Rails 3.2, we may no longer depend on rescue_from AbstractController::ActionNotFOund to catch the exception and redirect to a 404.

The fix is to configure exceptions_app so that errors are also routed:

https://github.com/vidibus/vidibus-routing_error#alternative-one.

I can submit a patch later if this sounds good.

from brigade.

kmcurry avatar kmcurry commented on August 11, 2024

I'm not well qualified to decide. Any second opinions out there?

from brigade.

rmcastil avatar rmcastil commented on August 11, 2024

@mchung sure. can you submit a pull request and we'll check it out?

from brigade.

kmcurry avatar kmcurry commented on August 11, 2024

I'm not able to verify pull request #116 on localhost (or even issue #45). It could be a problem with my local server. When I point to /locations and /notfound I get responses like:

Routing Error

No route matches [GET] "/notfound"
Try running rake routes for more information on available routes.

from brigade.

rmcastil avatar rmcastil commented on August 11, 2024

@kmcurry Sorry I've been missing in action. Had a crazy holiday. Did you just close this pull request?

from brigade.

kmcurry avatar kmcurry commented on August 11, 2024

yep!

On Mon, Jan 7, 2013 at 9:22 AM, Ryan Castillo [email protected]:

@kmcurry https://github.com/kmcurry Sorry I've been missing in action.
Had a crazy holiday. Did you just close this pull request?


Reply to this email directly or view it on GitHubhttps://github.com//issues/45#issuecomment-11953095.

Kevin Curry
Program Director
CfA Brigade
757.613.8158
GMT-5
http://brigade.codeforamerica.org

from brigade.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.