Agnostic support for CI systems about codecov-python

[stevepeak]

Hey! I'll be adding these patterns below if no CI provider is found

  commit="$VCS_COMMIT_ID"
  branch="$VCS_BRANCH_NAME"
  build_url="$VCS_BRANCH_URL"
  build="$VCS_BUILD_ID"
  pr="$VCS_PULL_REQUEST"
  slug="$VCS_SLUG"

CI names are specific to our backend because of icons and internal database linkage.

[adiroiban]

I think that instead of

build -> VCS_BUILD_ID
build_url -> VCS_BUILD_URL

we should have

build -> CI_BUILD_ID
build_url -> CI_BUILD_URL

as these variables are related to the CI system and not with the VCS

[stevepeak]

Good point :) I agree with that 👍 I'll adjust accordingly

[jayvdb]

This is solved?

[stevepeak]

Short answer: Yes, in the bash uploader, when on CI provider is discovered.

Taking another look at it and I think we need to always collect these details, by default, regardless or CI detection.

[jayvdb]

It looks like there were commits in the python uploader as well. Is that work in the python uploader not complete?

[stevepeak]

I'll take a look at the python uploader too. Thank you

[thomasrockhu]

This has been solved via 2f3d3ab