Show Win key pressed after unlocking PC about carnac

[cbo100]

I've only had a quick look at this, but to me it seems possible it's Windows not sending the Key Up message. Not really a bug, more like a limitation. Possibly a side effect of the secure desktop?

The winKeyPressed flag gets stuck on in KeyProvider.DetectWindowsKey as it seems the InterceptKeys.HookCallback is never notified of the Win key being released in some cases.

Reproducible:

1. Press Win + L
2. Ensure to hold the Win key down until the "Press CTRL+ALT+DEL to Unlock" screen appears
3. Upon unlocking the desktop again all keystrokes are reported as Win+[KEY]

If you very quickly release the Win key before the secure desktop is loaded then it does not have the problem.

[peteraritchie]

Okay, I see what's happening. I had originally thought it was a bug in Windows (which I was going to use a fuel for something else...) but it does seem to be something in Carnac. I've submitted a pull request with a change for this to simulate a key up event on the unlock of the desktop (if needed).

[JakeGinnivan]

Thanks for this. @shiftkey any thoughts on when you can migrate to squirrel and how we do deployment? Or should I just push clickonce update on the weekend?

[shiftkey]

@JakeGinnivan let's just push a ClickOnce update for now