Coder Social home page Coder Social logo

Comments (3)

AlemTuzlak avatar AlemTuzlak commented on June 3, 2024

@jfsiii Thank you for the report! I've been trying to figure this one out because it was reported to me but had no luck due to lack of info. This is greatly appreciated. Will try to replicate with this to find the root cause.

from remix-forge.

AlemTuzlak avatar AlemTuzlak commented on June 3, 2024

@jfsiii there have been some improvements to the underlying code, could you try this again if it works? I have a feeling it is due to an OS difference because when I test it on windows it works.

from remix-forge.

jfsiii avatar jfsiii commented on June 3, 2024

@AlemTuzlak Still no luck.

Here's some info about the before/initial routes

remix-routes-main.txt
tree-routes-main.txt

And here's what I saw running in VS Code

Screenshot 2023-12-18 at 7 50 43 PM

Here's the routes after conversion

remix-routes-forge.txt
tree-routes-forge.txt

The diff of the last line from the two tree outuput

- 21 directories, 53 files
+ 1 directory, 22 files

I'm not sure of the process for conversion but it's losing alot of routes. All (?) the routes in users/bulk-import/* for example.

In getting the screenshots for this response, I started fresh and ran it in VS Code again. This time I got only the "Flattening route to v2 convention finished!" success message but the results were still the same on disk.

We do have some non-route files in there (a components subdirectory in one, two? types.ts files)

ignoredFilePatterns from remix.config.js
  // ignore all files in routes folder to prevent
  // default remix convention from picking up routes
  ignoredRouteFiles: ['**/*'],
  routes(defineRoutes) {
    // uses the v1 convention, works in v1.15+ and v2
    return createRoutesFromFolders(
      defineRoutes,
      // optionally add the real ignored route files here as needed
      {
        ignoredFilePatterns: [
          // ignore (do not make accessible in UI) any files under `routes/` which:
          // start with a `.`
          '**/.*',
          // are named types.ts, types.tsx, components.ts, etc
          '**/{components,utils,types}.ts{,x}',
          // are in a routes/**/components, routes/**/utils, or routes/**/types directory
          '**/{components,utils,types}/*',
        ],
      }
    );

but there's only a few of them, and none a directory like users/bulk-import which is getting lost

└── users
    ├── $userId.change-password.tsx
    ├── $userId.edit.tsx
    ├── bulk-import
    │   ├── csv.ts
    │   ├── facility.tsx
    │   ├── index.tsx
    │   ├── upload.tsx
    │   └── validation-preview.tsx
    ├── bulk-import.tsx
    ├── create.tsx
    └── index.tsx

from remix-forge.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.