Observation Leak about masshortcut

[iluuu1994]

Oh just saw that it's because _shortcutView (the observer) has already been deallocated. This means there's no potential leak. But it would still be nice to see a fix.

[iluuu1994]

Ok by making the property shortcutView strong, it works.
Is this a proper fix in your opinion?

[iluuu1994]

Oh and FYI, this solved a pretty big memory leak for me.

[shpakovski]

Hello Ilija, thanks a lot for the problem report and sorry for the late reply. To cleanup the KVO properly, please try to set associatedUserDefaultsKey to nil in the controller's dealloc. I'm not sure about making the property shortcutView strong because it would create a retain cycle, so be careful.

[iluuu1994]

Oh you're right. If it's strong stopObservingShortcutView doesn't get called anymore...

[shpakovski]

There must be a controller class where you assign associatedUserDefaultsKey to the shortcutView. In the the same controller class, call shortcutView.associatedUserDefaultsKey = nil in dealloc. Does it help?

[iluuu1994]

Oh, I assign the associatedUserDefaultsKey in Interface Builder via Key-Value-Coding. Let me make some outlets and try.

[iluuu1994]

Thanks!!! That did it! Sorry I guess I didn't look though the example good enough.

[shpakovski]

No problem! Thanks for confirmation :)