optionNumberToString is not safe about coap-packet

[dcousens]

@JKRhb please see #22 for your answer 👍

[digitallyrefreshed]

I forgot to mention that the same goes for optionStringToNumber:

var optionStringToNumber = (function genOptionParser() {

 var code = Object.keys(numMap).reduce(function(acc, key) {

   acc += 'case \'' + numMap[key] + '\':\n'
   acc += '  return \'' + key +'\'\n'

   return acc
 }, 'switch(string) {\n')

 code += 'default:\n'
 code += 'return parseInt(string)'
 code += '}\n'

 return new Function('string', code)
})()

can be replaced with:

var optionStringToNumber = function(string){
  for (var key in numMap){
    if (numMap.hasOwnProperty(key)){
      if (numMap[key] == string){
        return key;
      }
    }
  }
  return parseInt(string);
}

[mcollina]

First, I'm very happy to see this used in the browser too!
(Have you tried porting node-coap too?)

Anyway, that technique was used because it's way faster than yours, and in something which is likely used as a server component (like this one) is important.
Are you using Browserify, right? In case, we can move that function into another file, and use the 'browser' field to let browserify pick the correct one.
Would you like to submit a PR that implements that behavior?

[digitallyrefreshed]

Yeah, I'm using browserify. node-coap is working fine now. I had to find suitable browserify or chrome ported version of dgram. The current version of dgram I use (chrome-dgram) does not (yet) support IPv6 so I had to comment out anything to do with IPv6. Other than that it's working.

Gotcha. Makes sense.

Sure, I'll submit a PR and and add my "fixes" there.

[mcollina]

Plus, if you can make it 'safe' to (not) crash when ipv6 is missing it will be great!

[JKRhb]

Revisiting the functions in question I was wondering if creating a switch statement like this is still considered faster or if the use of object literals has catched up in the meantime.