Comments (5)
ValentaTomas
commented on May 28, 2024
2
I made these changed in #21
from firecracker-task-driver.
ValentaTomas
commented on May 28, 2024
1
I would also appreciate this. I'm doing some custom changes to the task driver and even just letting the errors propagate as they are was really helpful.
Do you think just propagating the error here:
https://github.com/cneira/firecracker-task-driver/blob/master/driver/driver.go#L297
https://github.com/cneira/firecracker-task-driver/blob/master/driver/driver.go#L258
would be alright?
from firecracker-task-driver.
wimax-grapl
commented on May 28, 2024
(you'll note that the alloc_id is different, I accidentally captured a retry, but the same shows up for 8ee3098b.)
from firecracker-task-driver.
wimax-grapl
commented on May 28, 2024
I'm not the author of this plugin, but I think based on how other official supported Nomad drivers work, it'd be totally reasonable.
The vast majority of the StartTask return statements include the err in, say, the Docker driver:
https://github.com/hashicorp/nomad/blob/52faa167dd0e18685440de5b6613f397b5fa0aa8/drivers/docker/driver.go#L300
from firecracker-task-driver.
ValentaTomas
commented on May 28, 2024
@cneira I think we can close this issue.
from firecracker-task-driver.
Related Issues (15)
- Rootfs links not accessible HOT 1
- License HOT 2
- Dead lock stop jobs
- How to registry service to consul HOT 7
- Jailer HOT 2
- veth interface HOT 2
- Add support for address_mode = "alloc" HOT 1
- firecracker-task-driver err="rpc error: code = Unimplemented desc = unknown service plugin.GRPCStdio" HOT 3
- Request for examples HOT 1
- Readme improvements HOT 1
- Add support for firecracker v1.0.0 HOT 2
- Bug- Veth is not releasing when the MicroVM restart HOT 5
- Supporting snapshot, pause/restore HOT 1
- Bug install firecracker-task-driver HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from firecracker-task-driver.