Removing infoTemplate on setMapClickMode about cmv-app

[tmcgee]

There may be an issue identified here when the defaultMapClickMode is set to an empty string. I suspect that isn't a common scenario - at least not one that I recall having been discussed here in the last 5+ years.

Regarding this statement,

InfoTemplates that are set on Feature Layers should always be available and not removed

If the Feature Layer infoTemplates were always available, they would interfere with widgets such as Drawing/Editing tools - The infoWindow popping up unexpectedly when attempting to draw or edit a feature is disruptive. Draw and Edit are just examples. There are many contributed tools that interact with the map in a similar fashion that would be affected by this change in behavior.

Over the years, there have been many "challenges" identified in the approach taken by Esri within the 3.x API with regards to interacting with graphics on top of the map.This includes features from a Feature layer. CMV has addressed this in a specific way that has worked for many years with few compromises in functionality. Esri revisited and improved this approach in the 4.x API and is investing close to zero time in the 3.x API. As we move forward with working with the 4.x API, I highly doubt the CMV team will be re-examining how we interact with the 3.x API.

[apatriz]

Completely agree with the 'challenges' of working with graphics in 3.x and regarding the time invested in 3.x functionality vs moving forward with 4.x.

Regarding defaultMapClickMode -- it can often lead to poor UX (at least in my client's scenario) when panning around the map and accidental left-click events will register an identify popup with no results, or generally unwanted identify popups.
We decided to keep 'identify' as a right-click menu option, and leave left-click with default functionality -- setting defaultMapClickMode to empty string. Understand this may be an uncommon case.

setInfoWindowOnClick is what I use to toggle the default graphic popup behavior that might interfere in custom widgets (or Draw, Edit, Measurement, etc.).

I can see the issue with modifying all the community widgets to use the above method, but it may be possible to use that method in Identify, rather than removing the infoTemplate ? Not sure.