Comments (15)
Nice catch! And yeah, I think that changing EnvironmentHelper
to also return the default on an empty string is appropriate, @aaroalan.
from qpp-conversion-tool.
@nathandonato We have deployed a new version of the converter to production. Please try it out and see if that gets your file converted and submitted.
from qpp-conversion-tool.
Looks like the issue is a missing env var CPC_END_DATE
, CpcClinicalDocumentValidator.java
has this line LocalDate.parse(EnvironmentHelper.getOrDefault(END_DATE_VARIABLE, NEVER_ENDING))
but looks like it's returning an empty string instead of the defaultValue.
You can fix it locally if you se the env var in the docker-compose.test.yaml
...
environment:
- CPC_END_DATE=3000-01-01
...
from qpp-conversion-tool.
Update: Don't need to update the docker-compose file .env
file has CPC_END_DATE=
so that's why var is ''
from qpp-conversion-tool.
We'll double check the documentation to ensure that this is called out in the docs as an env var to modify. We can also just provide a default value in the .env
file.
from qpp-conversion-tool.
Maybe the EnvironmentHelper
should validate that value is not null and is not a empty string, What do you think?
from qpp-conversion-tool.
@aaroalan @nathandonato: We have added this issue to our backlog and it will be prioritized today. We will let you know via this issue when changes have been made.
from qpp-conversion-tool.
Thanks @sfradkin! I'm sure you're aware and will factor this into the priority, but it's probably worth overstating: CPC+ submissions are due in one week (2018-02-28).
from qpp-conversion-tool.
@nathandonato Yes we are aware of this. However, since there is a stated solution in this thread as to how to set the environment variable, and there is a publicly available sandbox at https://qpp.cms.gov/developers/conversion-tool-sandbox that uses our production code, that lowers the priority of this a bit.
from qpp-conversion-tool.
That makes sense, thanks for the follow up. But we are getting this error when doing QRDA III XML submissions (we assume this is the error; the response is error code 3, and this is the actual exception we get locally for the same file).
So we can use the environment variable solution in our testing, but is there any chance you guys will set the environment variable in production?
from qpp-conversion-tool.
Ah, sorry. I missed the part that you tried this as a real submission and got the same error. I can confirm that I am seeing that error with your file. We'll take a look at this to see what's going on as it's unrelated to the CPC_END_DATE.
from qpp-conversion-tool.
Sorry, that's my fault. I should have been more clear. Thanks for looking into it.
from qpp-conversion-tool.
@nathandonato Looking at this further it appears that you have a missing code in one of your supplemental data elements. We are already working on a fix for this situation so that it correctly outputs an error with the xpath rather than returning an "unexpected error". It's tough to eyeball the QRDA document to find the missing code, but that's where you can look.
We're going to work on getting this fix out as a hotfix to production by the end of the day tomorrow.
from qpp-conversion-tool.
@sfradkin We believe we found the issue. Thanks for pointing us in the right direction!
from qpp-conversion-tool.
With no response for over a week, I'm going to go ahead and close this issue as fixed.
from qpp-conversion-tool.
Related Issues (20)
- Sample Files for year 2021 HOT 2
- UUID errors on CMS156 for 2021 HOT 3
- Build of 14.5.0 throwing error on tools.jar HOT 1
- Conversion error from CMS347v4 HOT 3
- Error running the docker image: Keystore not found HOT 4
- XML file validation issue HOT 2
- Confirmation regarding XML file validation HOT 1
- Confirmation regarding XML file validation HOT 4
- QPP conversion tool 2022 HOT 2
- qpp update HOT 3
- NUMEx issue HOT 3
- Unable to execute docker-compose up HOT 1
- MIPS
- Are you done with qpp conversion tool 2023 updates HOT 5
- Are you done with qpp conversion tool 2023 updates? HOT 3
- Update for Conversion Tool 2023 HOT 6
- 2023 Release HOT 3
- Jar not found HOT 3
- Version Specific Measure GUID issue for validating File HOT 2
- CMS 156v11 Issue Version Specific Measure HOT 14
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from qpp-conversion-tool.