Comments (15)
assign l1,core
from cmssw.
New categories assigned: l1,core
@Dr15Jones,@makortel,@epalencia,@aloeliger,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks
from cmssw.
cms-bot internal usage
from cmssw.
A new Issue was created by @iarspider.
@makortel, @smuzaffar, @sextonkennedy, @rappoccio, @antoniovilela, @Dr15Jones can you please review it and eventually sign/assign? Thanks.
cms-bot commands are listed here
from cmssw.
from cmssw.
I think constexpr
should fix the one from cmssw i.e.
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::input_W'
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::lut_W'
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::lutSize'
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::lutOutSum_I'
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::lutOutSum_W'
undefined reference to `lutNN::LutNeuronLayerFixedPoint<8, 13, 16ul, 5, 11, 9, 5>::output_W'
and for undefined reference to
ap_int_base<5, false>::width'`, I guess we need to patch https://github.com/Xilinx/HLS_arbitrary_Precision_Types/blob/master/include/ap_int_base.h#L125 to have constexpr ?
from cmssw.
It compiles fine with non-DBG IB, explicitly checked with CMSSW_14_1_DBG_X_2024-05-09-2300 and el8_amd64_gcc12. What is difference between regular and DBG releases?
The L1Trigger/L1TMuonOverlapPhase2
package was recently added to CMSSW, could it be that it should be "registered" somewhere (its libraries known to some tools) to be dbg'ed?
from cmssw.
DBG
IBs are built with -g -O3 -DEDM_ML_DEBUG
flags and in this case the code https://github.com/cms-sw/cmssw/blob/master/L1Trigger/L1TMuonOverlapPhase2/interface/LutNeuronLayerFixedPoint.h#L64-L73 gets compiled https://github.com/cms-sw/cmssw/blob/master/FWCore/MessageLogger/interface/MessageLogger.h#L240-L252
from cmssw.
Thank you @smuzaffar
I confirm that usage of constexpr
fixes issues within OMTF code, but I think I am not able to fix them in header from AMD.
How to proceed? Should I prepare PR with fixes in OMTF and assuming that other thing will be fixed by someone else?
from cmssw.
We already patch the https://github.com/Xilinx/HLS_arbitrary_Precision_Types in cmsdist so in principle we could continue doing that.
Written that, it seems to me the frequency of problems with this package is increasing, and the package (in GitHub) seems practically unmaintained since 5 years, so I'm getting worried about long-term sustainability.
from cmssw.
OK, so I prepare PR with CMSSW fixes.
What concerns the external package I cannot comment, but at least from a quick look it is still recommended by Xylinx/AMD in HLS documentation...
from cmssw.
Written that, it seems to me the frequency of problems with this package is increasing, and the package (in GitHub) seems practically unmaintained since 5 years, so I'm getting worried about long-term sustainability.
I diffed against Vitis_HLS 2022.2 and it looks like there's only a handful of changes that are directly relevant to us (most of the changes don't apply to the Apache licensed version), and most of them look to be constexpr-related. These are sufficiently small that I think it would be ok to cherry pick those for the CMS version and make a PR to the Xilinx repo.
from cmssw.
We have had one PR (Xilinx/HLS_arbitrary_Precision_Types#1) sitting there for ~6 months without any reaction.
from cmssw.
#44974 and cms-sw/cmsdist#9193 should fix the DBG link errors
from cmssw.
I agree with @makortel, https://github.com/Xilinx/HLS_arbitrary_Precision_Types looks unmaintained. No updates in last 5 years and even the PR I opened to initialize the memory is open since NOV last year
from cmssw.
Related Issues (20)
- Build CMSSW_14_0_13_patch2_MULTIARCHS HOT 17
- MAHI-Alpaka improvements HOT 4
- Deployment of multi-architecture setup in 14_0_X HOT 43
- Noisy `ElectronSeedProducer` in 2024 and Phase-2 worfklows HOT 7
- [ASAN_X] RelVal 537.0: attempting free on address which was not malloc()-ed HOT 7
- Build CMSSW_14_0_14 HOT 49
- Build CMSSW_14_0_14_MULTIARCHS HOT 17
- Build CMSSW_14_1_0_pre6_ROOT633 HOT 13
- [ARM][ROOT6_X] Workflow 12846.0 step 3 crashed due to SIGSEGV in EvaluateMuonMVAID:muonMVAID HOT 6
- Build CMSSW_13_2_12 HOT 9
- Distribution of py3-law in cmssw HOT 11
- Discussion: Aligning Python Code Formatting with PEP8 vs. Readability Preferences HOT 21
- Build CMSSW_13_2_12 HOT 49
- Runtime crash when forcing only pixel tracking+vertexing on `serial_sync` backend HOT 24
- Online-DQM occasionally not picking up the correct IOVs ? HOT 5
- pileupCalc.py error HOT 7
- [ASNEEDED_X] Multiple RelVals failing with SIGSEGV HOT 5
- redundant pidgid and charge in NANO for electron (at least) HOT 5
- [ASAN] SubmitPVsplit and test_MC_23_setup failing for unknown reason HOT 3
- Stop Building old CMSSW releases HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmssw.