Comments (9)
@rchatter can you setup the scale and smearing for lagacy 2017? I would go again with a separate diphotonSystematics config file that is then specified in the meta conditions.
@threiten @edjtscott I think we need at least scale and smearings to go ahead with the differential pho ID corrections
from flashgg.
Nice catch! Completely forgot to update the metaconditions.
Shall be cross-check if the updates needed for UL17 JEC/JER and also update the B-tagging SFs on top of this and then close the PR?
from flashgg.
Mc is fine, the recommended one for data is v28 (https://twiki.cern.ch/twiki/bin/view/CMS/PdmVRun2LegacyAnalysisSummaryTable). I think v17 is still fine for microAOD production, we will update to v28 with any coming PR related to this.
from flashgg.
Hi Simone,
Yes I have everything to push this diphoSyst file(privately provided to a few people already) as you asked. Just want to explicitly test it on the DoubleEG Legacy17 dataset before committing[unfortunately there seems to have been an issue in the MuAOD production].
The reason for this extra caution is that nominally for all of CMS we changed the scale correction file format and the corresponding EGamma scale correction class to deal with it (This was a long standing request from multiple people, to migrate the scale correction to DB and this change in format is the first step). All future Legacy scale correction files will be in the new format. However for continuity in HGG I also produced the file in the old format[like we currently have for the 3 years]. Hence also checking that it works fine with the dipho data.
Rajdeep
from flashgg.
Thomas is going to produce tnp ntuple for the pho ID correction
training, I guess we can use those to have the validation (he will share
them with you in case you want to take a look), so I think it is best if
you can make a PR with the changes needed to run with the old format and
we will migrate everything together once the new format is available for
all years. What do you think?
from flashgg.
I think we can almost close this issue @simonepigazzini since @rchatter made the PR and it has been merged. However I notice that this line in the legacy meta conditions file was not changed - it should be updated right? If so that should be fixed first.
from flashgg.
Yes good idea, we can keep this open until those are confirmed / sorted
from flashgg.
I believe we can close this now right?
from flashgg.
Yes, all systematics for UL2017 have been confirmed!
from flashgg.
Related Issues (20)
- Can't build in 80X HOT 4
- [94X] size limits and crab submission HOT 3
- QGTagger implementation HOT 4
- Diphoton systematics for 2018 and review of 2016/2017 HOT 2
- Improve HTCondor usage HOT 1
- Cleanup Validation + finalize technical validation tool HOT 1
- Review EGM scale factors application
- Overlap removal in Hgg MC samples HOT 3
- Muon SF systematics HOT 1
- Category dumper cleanup HOT 5
- setWeight implementation and use related to bTagReshapeWeights
- Cleanup lepton selection codes HOT 1
- WorkspaceStd Slow to Start for Signal HOT 3
- Inconsistency in 2016 Data Events HOT 6
- missing btag reshape uncertainties in flashggJetSystematics_cfi.py
- RFE: please document best practice for local CERN use with AFS/EOS
- Datasets from PR 1298 are causing flashgg/Metadata/JobConfig.py to fail HOT 2
- UL16 PreVFP Data (DoubleEG/..Run2016X..) Not Parsed by fggRunJobs HOT 2
- pileupConfiguration_cfi.py is not found when running flashgg HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flashgg.