Comments (6)
I know it's quite weird... At first, I thought it was due to some error in my files, but I have cleaned the cache and updated Deno to 1.4.6
and it's still happening.
I have downloaded this repo and I have run the tests but they are ok so...
I will try to investigate what's being left hanging.
from superoak.
Sorry ignore those two replies, what you have said works great. Thanks!
from superoak.
Hey @antoniogamiz thanks for raising - not ideal at all given that really is the simplest usecase!
Will try to spare some time soon to investigate - if you have time and are keen, please do have a dive into the code to figure out what async/promising thing is being left hanging.
It's odd this hasn't been picked up in the tests but haven't touched this in a month and may be that something in Oak / Deno has moved along since September... or just have been super lucky (or unlucky depending on how see it) with an async op race condition.
from superoak.
Haven't dug too deeply, but from a quick reminder of the code, performing:
const request = await superdeno(app);
Will launch an Oak server and resolve with a promise which we are awaiting. Given nothing then stops said Oak sever, my guesses are that it (the server) is effectively the async op that is not cleaned up (or more accurately the async iterator inside the Oak server that processes requests hasn't been escaped).
Hence I'm curious if the issue goes away if you actually complete the usage of superdeno
as documented and make an action / assertion - superdeno has it's own internal logic to close the Oak server using an AbortController
, and this will only be fired when the underlying superdeno .end()
method is called, either implicitly or explicitly (REF: https://github.com/asos-craigmorten/superdeno/blob/main/src/test.ts#L350)
For instance, updating to the following solves it for me:
import { Application} from "https://deno.land/x/[email protected]/mod.ts";
import { superoak } from "https://deno.land/x/[email protected]/mod.ts";
const app = new Application();
app.use((ctx: any) => {
ctx.response.body = "Hello world!";
});
Deno.test("Example", async () => {
const request = await superoak(app);
await request.get("/"); // Need to invoke at least one superdeno method otherwise the underlying server is left runner forever (well... until it gets cleaned up by Deno which will tell you off).
});
from superoak.
And why does this fail, then? It produces the same error:
import { Application } from "https://deno.land/x/[email protected]/mod.ts";
import { superoak } from "https://deno.land/x/[email protected]/mod.ts";
const app = new Application();
app.use((ctx: any) => {
ctx.response.body = "Hello world!";
});
Deno.test("Example", async () => {
const request = await superoak(app);
await request.get("/").expect({});
});
from superoak.
I'm passing an object because my endpoint returns a JSON, so I want to test that.
from superoak.
Related Issues (16)
- error: TS2345 [ERROR]: Argument of type 'Application<Record<string, any>>' is not assignable to parameter of type 'string | Application<Record<string, any>>'. HOT 4
- callback function parameters are displaced. HOT 2
- Need a FAQ section in README.md HOT 3
- ReferenceError: Access to "location", run again with --location <href> HOT 2
- Project does not compile with latest version of oak using Deno 1.3.0 HOT 7
- How to test cookie based sessions? HOT 3
- Tests hang when running with --unstable (Oak 7.3, SuperOak 4.2, Deno 1.9.2) HOT 13
- Document how to send request body, headers, etc HOT 1
- Testing error case fails HOT 5
- Example fails with "Re-exporting a type.." HOT 3
- Does not send correctly an application/x-www-form-urlencoded HOT 2
- Demo Code Throws Errors HOT 1
- Suggestion - Jest features HOT 4
- I can`t install it HOT 4
- AssertionError: Test case is leaking async ops. HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from superoak.