Comments (5)
That's great! I'll merge this into master when gentoo catches up with kernel 4.12.x on its stable distro. Thanks!
from lg4l.
I've tracked down the offending change to torvalds/linux@733aca9
As far as I can see this started out with kernel 4.12:
cipi@pink ~/src/linux $ git branch --contains 733aca90300b76575b8a465dc49cbed7a991fd8b
* master
cipi@pink ~/src/linux $ git tag --contains 733aca90300b76575b8a465dc49cbed7a991fd8b
v4.12
v4.12-rc1
v4.12-rc2
v4.12-rc3
v4.12-rc4
v4.12-rc5
v4.12-rc6
v4.12-rc7
v4.13-rc1
v4.13-rc2
v4.13-rc3
v4.13-rc4
From that commit it seems the solution is to replace hdev->minor
with ((struct hiddev *)hdev->hiddev)->minor
. I am not sure what are the guarantees that the void *hiddev
member is not null though.
I'll make a branch with a compilable version and maybe you can help with doing some tests. I have not reached yet kernel version 4.12 on my machine, and I don't have the time to set up a test VM at the moment.
from lg4l.
I've added some changes to branch kernel-4.12. I built it with a 4.12.4 kernel on my machine, but I didn't have the time to fiddle with the kernel config, so I cannot run it.
Does it build on yours? can you test if the the driver actually works, or does it hang the kernel?
from lg4l.
Yes, it seems work well in my machine (Arch Linux with stardard kernel, version 4.12.4-1). I have a G19 and can set led colors and brightness without problem. 👍
from lg4l.
Gentoo has bumped the kernels to 4.12.x, but due to the spectre/meltdown problems they downgraded it back to 4.9.x. Now gentoo has not stabilized 4.14.52 with retpoline and such. I've already merged this into master, and managed the gentoo problem from my gentoo overlay.
This can be closed imo.
from lg4l.
Related Issues (10)
- Kernel crashes on module removal HOT 1
- Unable to bind g15v1
- Ubuntu 18 HOT 27
- $PWD
- hid_ginput crash with 3.13 and 3.14 kernels on start of g15 client utilities HOT 7
- Cannot build in 3.17+ kernels HOT 4
- Review keyboard initialization sequences HOT 1
- Project status HOT 1
- Pull Request #5 pending for a year now HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from lg4l.