Error building with kernel 4.12.3 about lg4l

[CMoH]

That's great! I'll merge this into master when gentoo catches up with kernel 4.12.x on its stable distro. Thanks!

[CMoH]

I've tracked down the offending change to torvalds/linux@733aca9

As far as I can see this started out with kernel 4.12:

cipi@pink ~/src/linux $ git branch --contains 733aca90300b76575b8a465dc49cbed7a991fd8b
* master                                                                                                                                                                                                                                     
cipi@pink ~/src/linux $ git tag --contains 733aca90300b76575b8a465dc49cbed7a991fd8b                                                                                                                                                       
v4.12                                                                                                                                                                                                                                        
v4.12-rc1                                                                                                                                                                                                                                    
v4.12-rc2                                                                                                                                                                                                                                    
v4.12-rc3                                                                                                                                                                                                                                    
v4.12-rc4                                                                                                                                                                                                                                    
v4.12-rc5                                                                                                                                                                                                                                    
v4.12-rc6                                                                                                                                                                                                                                    
v4.12-rc7                                                                                                                                                                                                                                    
v4.13-rc1                                                                                                                                                                                                                                    
v4.13-rc2                                                                                                                                                                                                                                    
v4.13-rc3                                                                                                                                                                                                                                    
v4.13-rc4

From that commit it seems the solution is to replace hdev->minor with ((struct hiddev *)hdev->hiddev)->minor. I am not sure what are the guarantees that the void *hiddev member is not null though.

I'll make a branch with a compilable version and maybe you can help with doing some tests. I have not reached yet kernel version 4.12 on my machine, and I don't have the time to set up a test VM at the moment.

[CMoH]

I've added some changes to branch kernel-4.12. I built it with a 4.12.4 kernel on my machine, but I didn't have the time to fiddle with the kernel config, so I cannot run it.

Does it build on yours? can you test if the the driver actually works, or does it hang the kernel?

[ogarcia]

Yes, it seems work well in my machine (Arch Linux with stardard kernel, version 4.12.4-1). I have a G19 and can set led colors and brightness without problem. 👍

[CMoH]

Gentoo has bumped the kernels to 4.12.x, but due to the spectre/meltdown problems they downgraded it back to 4.9.x. Now gentoo has not stabilized 4.14.52 with retpoline and such. I've already merged this into master, and managed the gentoo problem from my gentoo overlay.

This can be closed imo.