Comments (2)
The concept of having to place a file in a folder to comment/uncomment manually is really awkward. We should move away from this and instead introduce an API (see #44).
@drlemmus Can you explain why some entries need to be manually added to comment
and uncomment
? Why aren't they picked up automatically when crawling the databanks? (I'm have a gap in knowledge here and it'd be nice to fill it).
I'm also wondering what happens when an entry is added to comment and processed, and then that entry gets picked up later on by the crawler/annotator. Since the annotator will have a more up-to-date version, the manual changes will be overwritten. Is that always correct?
from whynot2.
The problem with an API that I didn't mention before is that there need to be backups of the database, because there is no 'paper trail'. The fact that we lost the database now and we still have the comments in the comment/uncomment directories to restore it shows that it is convenient to have such directories. By the way, restoring the comments should be a priority and crawling the databanks should be a priority. We cannot test if the databanks are not indexed yet.
@jonblack If the reason why an entry cannot be made is caused by a technical difficulty that was not know a comment may need to be added manually after analysis of the input data. That is why we need to manually add comments.
Now if a previous problem is overcome in a new version of the software making the entries (or by remediation of the input data), the missing entries with a particular comment can be made. In the original idea, we would only try to make these if there was no comment saying that the entry cannot be made. That is, new entries are made if they are of the 'missing-unannoted' group, so first the existing comments had to be removed.
However, we are currently working with skip lists rather than directly with the info administrated in WHY_NOT, so the above reasoning does not apply fully. Instead we can now make entries by removing them from the skip list (note that this is an extra step that requires access to the skip lists). Now if the entries are made, they move from 'missing' to 'present' and any existing comments are trashed. However, if there are entries that cannot be made for a different reason a new comment and the existing comment are stored. At this point however, the existing comment is invalid and must be removed. That is why we need the uncomment mechanism.
from whynot2.
Related Issues (20)
- Remove dead code HOT 3
- Use package namespaces in imports
- Coding standards
- Write unit and integration tests
- No lists of entries are generated HOT 3
- Annotations cannot be accessed
- Circle diagrams make no sense HOT 3
- Make circle diagrams clickable again HOT 2
- Show pie chart as two concentric circles
- Comments page is empty HOT 1
- statistics page shows wrong information HOT 1
- Not all databanks are indexed (correctly) HOT 3
- Replace top_highest with mongo query
- Crawl failing HOT 3
- Expand API to allow modifications
- Send email when exception not caught HOT 1
- Exception: no such databank: PDB_REDO HOT 4
- When is an entry considered missing? HOT 1
- How to comment entries missing in PDB? HOT 2
- structure factors missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from whynot2.