DVB Subtitles not available about mpc-hc

[adipose]

I will test this out.

[adipose]

It's caused by the removal of these lines:

    if (CComQIPtr<IAMStreamSelect> pSS = m_pGB) {
        ASSERT(false);
        addStreamSelectFilter(pSS);
    }

In this commit.

I don't fully understand the commit, but I can say that this code isn't ever finding IAMStreamSelect for DVB:

Also, if the pSS line is the only thing working, we should probably remove the ASSERT.

[adipose]

@clsid2 , maybe take a look.

[JGallium]

Nice Find!

I don't have the tools installed to compile an exe myself, but I can test any new versions that get uploaded

[adipose]

I can make you a test build.

[JGallium]

ok, great, wanna do it now?

[adipose]

I will upload in a bit. I am on an old branch testing it at the moment.

[JGallium]

ok, sure no hurry, I'm pretty free until next week

[adipose]

https://mega.nz/file/5UoSRSab#zS6yA4cSr0gaFlNq4-8znnGG1Ip8gYJgH8kPkxfsdbI

[JGallium]

That fixes it for me, Thanks!

EDIT: Note that if I just run the bare .exe file it doesn't work, but if I unzip the whole archive and double-click the .exe from there it does work.

(I'm using an Astrometa DVB-T2 USB dongle in Windows 10/11 to receive Freeview digital TV in the UK)

I hope this change can get rolled out in the official release and the K-Lite Codec packs soon.

Great stuff, should I close this myself?

[adipose]

You can leave it open, but if my PR is accepted you can close it.

The exe and libraries are part of one build so they should be used together.