Comments (5)
I guess memory barrier between cstring s and s->type is needed. maybe it's unusefu. Should I remove then?
from cstring.
I think here's not the situation '__sync_synchronize' needed. No memory ordering need to be guaranteed because you have used lock during interning cstring, which is the only share data in multithread. No where else can change s->type.
Anyway it affects little, removing it perhaps improve performance a little.
from cstring.
I mean
cstring
cstring_persist(const char * cstr, size_t sz) {
cstring s = cstring_clone(cstr, sz);
if (s->type == 0) {
s->type = CSTRING_PERMANENT;
s->ref = 0;
}
__sync_synchronize();
return s;
}
from cstring.
Do you worried about "return s" runs before "if (s->type == 0)" or "cstring_clone"?
But I can't tell the problem it cause without '__sync_synchronize();'.
from cstring.
yeah, maybe s was read by flowing cstring_grab() before s->type changed.
I'm not sure. But I guess I can remove these '__sync_synchronize();'
from cstring.
Related Issues (7)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cstring.