User error reporting about netlify-plugin-cloudinary

[colbyfayock]

cool thanks for the input @ehmicky

[colbyfayock]

@ehmicky set up a PR at #16 to switch error handling. I would imagine it's best practice to fail the plugin and not the build in this case, would you agree?

my only concern was that if someone installed the plugin, never added their cloudname, and saw it "didn't work" but failed to check the logs with a passing build, that they would think that the plugin just didn't work, which is why i was failing the builds in the first place. thoughts?

[ehmicky]

Whether the plugin or the whole build should be failed depends on whether it is acceptable for users to deploy their site even if the plugin failed. For example, for an analytics-related plugin, it might be the case. In the case of this plugin, images of the site would not be optimized and delivered by Cloudinary. I am leaning towards thinking this might be a case where the build should fail. Also for the reason you mentioned: if only the plugin was failed (not the build), missing inputs (such as cloudname) might be missed by users who do not check their build logs. What do you think?

Please note that both utils.build.failBuild() and throwing an error fail the build. The only difference is how the error is reported in the Netlify UI: as a user error or as a plugin error.