IE8 bug about hideshowpassword

[tylersticka]

@pixelthing Great catch, thanks!

It might not be the craziest idea to provide a fallback solution that toggles between separate <input type="text"> and <input type="password"> elements, in case IE < 9 is a requirement for someone. The plugin's simple enough that it seems like a shame for this one issue to prevent folks from using it in IE 8 entirely.

[tylersticka]

@pixelthing Just to give you an update, the replacement solution proved a bit untenable... it turns out you can't even read an <input> type property more than once in IE < 9, so it becomes really hard to maintain styles and attributes for duplicate elements.

The good news is that I've got a test working that seems to figure out if that feature is supported or not. The next major plugin update will use this to fail more gracefully, but in the meantime I thought I'd pass it along in case it's helpful for determining whether or not to enable the plugin:

var canSetInputAttribute = (function(){
  var body = document.body
    , input = document.createElement('input')
    , result = true;
  if (! body) {
    body = document.createElement('body');
  }
  input = body.appendChild(input);
  try {
    input.setAttribute('type', 'text');
  } catch (e) {
    result = false;
  }
  body.removeChild(input);
  return result;
}());

if (canSetInputAttribute) { /* hideShowPassword, etc. */ }

[pixelthing]

brilliant - much better feature detection than the method I was using...
thanks.

[tylersticka]

@pixelthing Just released version 2 of the plugin, and it should fail much more gracefully now without any additional checks.