Comments (4)
Ah, the dreaded browser autofill. This shouldn't have anything to do with the plugin, but with the behavior of the username/password fields on your page. (If you were to remove the plugin but keep the <input>
elements, I'd bet you'd still see them auto-filled.)
In a future version of the plugin, I'd like to have some sort of "recommended" option for dealing with this. Currently, there's no magic solution.
One thing you can do is try disabling the browser autofill on the <input>
elements themselves. I recommend this Mozilla article for doing that.
You can also just hide the password by default. If that's not your style, you could defer enabling that field until you're sure it isn't autofilled... though that can be complicated. There are many techniques for doing so and even an autofill event plugin.
We'll be exploring this further in the future. In the meantime, if you stumble upon a combination of solutions that work for you, please let us know so we can incorporate that knowledge into the plugin.
from hideshowpassword.
Oh, thank you for your quick and elaborate reply. 👍
I see your point about the autofill issue. I will also think over how to counter it based on your idea and will let you know. Meanwhile, i will keep watching your github. :0) Thank you so much for your reply.
from hideshowpassword.
I think the ideal implementation of the “Show password” feature would be as follows:
- the control is initially disabled (HTML
disabled
attribute) - when the user edits the password field for the first time, confirm the the current value has been produced from user input (i.e. it wasn’t autofilled), and only then enable the control
You can see this functionality in practice here: https://www.youtube.com/watch?v=Dt8np9kYCVM
@tylersticka Please consider adding this as an option.
from hideshowpassword.
Thanks, @simevidas! Regarding this portion:
when the user edits the password field for the first time, confirm the the current value has been produced from user input (i.e. it wasn’t autofilled)
Any advice on how one would reliably do that?
from hideshowpassword.
Related Issues (20)
- Auto left and right margins not inherited in Firefox HOT 1
- Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array HOT 4
- Rely more on CSS and less on JS for styles
- Split basic hide/show functionality from toggle UI
- Rendering issue when displayed on a modal form. HOT 2
- browserify require is broken when jQuery versions mismatch HOT 5
- Modernizr >= 2 and >= 3 use touchevents insted touch HOT 3
- Bower install fails HOT 5
- Can we do this with just CSS in supported browsers?
- Attach to hover event HOT 4
- Can't change button title "Show Password" HOT 2
- hideToggleUntil is not documented HOT 3
- Possibility to use existing wrapper (parent) element HOT 1
- Some of the demo doesn't work on Windows 8.1 touchscreen PC in Chrome, Firefox HOT 23
- Disable added inline styles HOT 2
- jquery dependency in wordpress HOT 2
- Keyboard focus lost on toggle in iOS Safari 12.1.2
- About this plugin, how can the focus skip the display password button after pressing the [TAB] key? HOT 1
- Configure globally HOT 5
- Classes should be in kebab-case HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hideshowpassword.