Comments (2)
@jbarreiros Great catch! Changes to the <input>
field typically only occur when the user or dev actually changes it's state from "shown" to "hidden" (or vice-versa). But in the case of the class-name, that really decreases the usefulness of the class.
The line you identified is indeed what's preventing the class from being assigned initially, but it's also preventing unnecessary changes from occurring as the plugin is used. I think the issue is that we're adding the non-state-specific class-name within a method that is responsible for updating the state of the element, when in reality that should be part of the init()
method.
Marked as a bug, will fix in a minor release as soon as we're able. Thanks for flagging this!
from hideshowpassword.
@jbarreiros Thank you for your patience! Just pushed v2.0.2 with a fix for this. You should now notice that any <input>
element manipulated by the plugin at all gets the hideShowPassword-field
class (or alternatively whatever className
you pass as an option).
from hideshowpassword.
Related Issues (20)
- Auto left and right margins not inherited in Firefox HOT 1
- Wrapper margins are still inherited even when not included in the wrapper object's inheritStyles array HOT 4
- Rely more on CSS and less on JS for styles
- Split basic hide/show functionality from toggle UI
- Rendering issue when displayed on a modal form. HOT 2
- browserify require is broken when jQuery versions mismatch HOT 5
- Modernizr >= 2 and >= 3 use touchevents insted touch HOT 3
- Bower install fails HOT 5
- Can we do this with just CSS in supported browsers?
- Attach to hover event HOT 4
- Can't change button title "Show Password" HOT 2
- hideToggleUntil is not documented HOT 3
- Possibility to use existing wrapper (parent) element HOT 1
- Some of the demo doesn't work on Windows 8.1 touchscreen PC in Chrome, Firefox HOT 23
- Disable added inline styles HOT 2
- jquery dependency in wordpress HOT 2
- Keyboard focus lost on toggle in iOS Safari 12.1.2
- About this plugin, how can the focus skip the display password button after pressing the [TAB] key? HOT 1
- Configure globally HOT 5
- Classes should be in kebab-case HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hideshowpassword.