Coder Social home page Coder Social logo

Comments (2)

tylersticka avatar tylersticka commented on June 17, 2024

@jbarreiros Great catch! Changes to the <input> field typically only occur when the user or dev actually changes it's state from "shown" to "hidden" (or vice-versa). But in the case of the class-name, that really decreases the usefulness of the class.

The line you identified is indeed what's preventing the class from being assigned initially, but it's also preventing unnecessary changes from occurring as the plugin is used. I think the issue is that we're adding the non-state-specific class-name within a method that is responsible for updating the state of the element, when in reality that should be part of the init() method.

Marked as a bug, will fix in a minor release as soon as we're able. Thanks for flagging this!

from hideshowpassword.

tylersticka avatar tylersticka commented on June 17, 2024

@jbarreiros Thank you for your patience! Just pushed v2.0.2 with a fix for this. You should now notice that any <input> element manipulated by the plugin at all gets the hideShowPassword-field class (or alternatively whatever className you pass as an option).

from hideshowpassword.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.