Coder Social home page Coder Social logo

Comments (9)

cf-gitbot avatar cf-gitbot commented on June 12, 2024

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/130619237

The labels on this github issue will be updated when the story is started.

from ruby-buildpack.

sesmith177 avatar sesmith177 commented on June 12, 2024

Hello @tyyko,

Thanks for the report. We will update the buildpack to use v0.1.7

from ruby-buildpack.

flavorjones avatar flavorjones commented on June 12, 2024

See related https://www.pivotaltracker.com/story/show/130641297 where we should be watching libyaml for new releases.

from ruby-buildpack.

sclevine avatar sclevine commented on June 12, 2024

Race condition -- didn't realize you already made a story: https://www.pivotaltracker.com/story/show/130641431

from ruby-buildpack.

sesmith177 avatar sesmith177 commented on June 12, 2024

We decided to remove libyaml from the buildpack in 6a38bf7.

Instead, we use the system-provided libyaml library which has been patched against that CVE.

We expect to release a new version of the Ruby buildpack shortly.

from ruby-buildpack.

jchesterpivotal avatar jchesterpivotal commented on June 12, 2024

Released in v1.6.25.

from ruby-buildpack.

schneems avatar schneems commented on June 12, 2024

I looked at the patch, notice in one of the deleted lines there was some logic to clear out previously installed gems after we had to update the libyaml version. I did some digging, it came from heroku/heroku-buildpack-ruby#224. I'm not quite sure how psych links to libyaml or under what conditions a cache purge is required.

from ruby-buildpack.

flavorjones avatar flavorjones commented on June 12, 2024

@schneems thanks for pointing this out. Everything we're shipping in the buildpack, and any gems that get built during staging, will all be dynamically linked against the rootfs's libyaml. So there shouldn't be any side effects to no longer purging the cache to force a recompile. An update to the underlying shared library should theoretically always be sufficient.

from ruby-buildpack.

jchesterpivotal avatar jchesterpivotal commented on June 12, 2024

I'm a bit vague here. For CF we get a fresh container each time, though the buildpack itself is cached. Gems aren't cached.

But it might be a line Heroku need to retain on any servers where the FS is reused for multiple staging events, because the gems might be cached between staging events.

I'm not sufficiently familiar with Heroku's implementation to say either way.

from ruby-buildpack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.