Build release fails after submodules update to 11.2.1 about app-autoscaler-release

[silvestre]

Hi @fdalfons, when we build our release our pipelines executes the following code before executing bosh create-release:

make generate-fakes generate-openapi-generated-clients-and-servers go-mod-tidy go-mod-vendor db scheduler

https://github.com/cloudfoundry/app-autoscaler-release/blob/main/ci/autoscaler/pipeline.yml#L461

Would it be possible to also add this into your build pipeline?

[fdalfons]

Hi @silvestre,

here is the script we use in our pipeline, https://github.ibm.com/concourse/autoscaler-pipelines/blob/develop/scripts/autoscaler/build-bosh-release.sh (let me know if you access it).
In any case, these are the meaningful lines:

cd app-autoscaler-bluemix/releases/app-autoscaler-release
./scripts/update
RELEASE_VERSION=$(git describe --tags | awk -F- '{print $1}' | sed 's/v//g')
bosh create-release --tarball ${outputDir}/app-autoscaler-release-${RELEASE_VERSION}.tgz --version ${RELEASE_VERSION}

As you can see from the complete log:

+ cd app-autoscaler-bluemix/releases/app-autoscaler-release
+ ./scripts/update
go: downloading github.com/xeipuuv/gojsonschema v1.2.0
go: downloading github.com/onsi/ginkgo/v2 v2.13.0
go: downloading github.com/onsi/gomega v1.29.0
go: downloading code.cloudfoundry.org/lager/v3 v3.0.2
go: downloading github.com/maxbrunsfeld/counterfeiter/v6 v6.7.0
go: downloading golang.org/x/crypto v0.14.0
go: downloading github.com/go-chi/chi/v5 v5.0.10
go: downloading code.cloudfoundry.org/clock v1.1.0
go: downloading code.cloudfoundry.org/cfhttp/v2 v2.0.1-0.20230113212937-05beac96f8c7
go: downloading github.com/gorilla/mux v1.8.1
go: downloading github.com/nu7hatch/gouuid v0.0.0-20131221200532-179d4d0c4d8d
go: downloading gopkg.in/yaml.v3 v3.0.1
go: downloading github.com/pivotal-cf/brokerapi/v10 v10.1.1
go: downloading github.com/tedsuo/ifrit v0.0.0-20230516164442-7862c310ad26
go: downloading github.com/prometheus/client_golang v1.17.0
go: downloading github.com/hashicorp/go-retryablehttp v0.7.4
go: downloading golang.org/x/exp v0.0.0-20231006140011-7918f672742d
go: downloading go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux v0.45.0
go: downloading github.com/patrickmn/go-cache v2.1.0+incompatible
go: downloading go.opentelemetry.io/otel v1.19.0
go: downloading github.com/go-sql-driver/mysql v1.7.1
go: downloading code.cloudfoundry.org/go-loggregator/v9 v9.0.8
go: downloading github.com/jackc/pgx/v5 v5.4.3
go: downloading dario.cat/mergo v1.0.0
go: downloading go.opentelemetry.io/otel/sdk v1.19.0
go: downloading code.cloudfoundry.org/go-log-cache/v2 v2.0.5
go: downloading github.com/stretchr/testify v1.8.4
go: downloading github.com/rubyist/circuitbreaker v2.2.1+incompatible
go: downloading github.com/jmoiron/sqlx v1.3.5
go: downloading google.golang.org/grpc v1.59.0
go: downloading github.com/cenkalti/backoff/v4 v4.2.1
go: downloading go.opentelemetry.io/otel/trace v1.19.0
go: downloading github.com/pkg/errors v0.9.1
go: downloading golang.org/x/net v0.17.0
go: downloading github.com/golang/protobuf v1.5.3
go: downloading github.com/gorilla/websocket v1.5.1
go: downloading github.com/steinfletcher/apitest v1.5.15
go: downloading code.cloudfoundry.org/tlsconfig v0.0.0-20231017135636-f0e44068c22f
go: downloading golang.org/x/time v0.4.0
go: downloading github.com/ogen-go/ogen v0.77.0
go: downloading github.com/openzipkin/zipkin-go v0.4.1
go: downloading github.com/xeipuuv/gojsonreference v0.0.0-20180127040603-bd5ef7bd5415
go: downloading github.com/pborman/uuid v1.2.1
go: downloading github.com/google/go-cmp v0.6.0
go: downloading github.com/hashicorp/go-cleanhttp v0.5.2
go: downloading github.com/hashicorp/go-hclog v1.2.0
go: downloading github.com/felixge/httpsnoop v1.0.3
go: downloading github.com/sclevine/spec v1.4.0
go: downloading github.com/onsi/ginkgo v1.16.5
go: downloading github.com/drewolson/testflight v1.0.0
go: downloading gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c
go: downloading github.com/beorn7/perks v1.0.1
go: downloading github.com/cespare/xxhash/v2 v2.2.0
go: downloading github.com/prometheus/client_model v0.4.1-0.20230718164431-9a2bf3000d16
go: downloading github.com/prometheus/common v0.44.0
go: downloading github.com/prometheus/procfs v0.11.1
go: downloading golang.org/x/sys v0.13.0
go: downloading google.golang.org/protobuf v1.31.0
go: downloading github.com/go-logr/logr v1.2.4
go: downloading github.com/blang/semver/v4 v4.0.0
go: downloading github.com/grpc-ecosystem/grpc-gateway/v2 v2.18.0
go: downloading go.opentelemetry.io/otel/metric v1.19.0
go: downloading github.com/go-logr/stdr v1.2.2
go: downloading google.golang.org/genproto/googleapis/api v0.0.0-20230822172742-b8732ec3820d
go: downloading github.com/cenk/backoff v2.2.1+incompatible
go: downloading github.com/facebookgo/clock v0.0.0-20150410010913-600d898af40a
go: downloading github.com/peterbourgon/g2s v0.0.0-20170223122336-d4e7ad98afea
go: downloading github.com/lib/pq v1.10.9
go: downloading github.com/mattn/go-sqlite3 v1.14.14
go: downloading google.golang.org/genproto v0.0.0-20230822172742-b8732ec3820d
go: downloading github.com/jackc/puddle/v2 v2.2.1
go: downloading github.com/pmezard/go-difflib v1.0.0
go: downloading github.com/davecgh/go-spew v1.1.1
go: downloading code.cloudfoundry.org/go-diodes v0.0.0-20221212174934-b8cb650f2489
go: downloading google.golang.org/genproto/googleapis/rpc v0.0.0-20230822172742-b8732ec3820d
go: downloading github.com/xeipuuv/gojsonpointer v0.0.0-20180127040702-4e3ac2762d5f
go: downloading golang.org/x/tools v0.14.0
go: downloading github.com/google/uuid v1.4.0
go: downloading github.com/go-faster/errors v0.7.0
go: downloading github.com/go-faster/jx v1.1.0
go: downloading github.com/fatih/color v1.15.0
go: downloading github.com/mattn/go-colorable v0.1.13
go: downloading github.com/mattn/go-isatty v0.0.20
go: downloading github.com/kr/pretty v0.3.1
go: downloading github.com/matttproud/golang_protobuf_extensions v1.0.4
go: downloading github.com/jackc/pgservicefile v0.0.0-20221227161230-091c0ba34f0a
go: downloading github.com/jackc/pgpassfile v1.0.0
go: downloading golang.org/x/text v0.13.0
go: downloading github.com/square/certstrap v1.3.0
go: downloading golang.org/x/sync v0.4.0
go: downloading github.com/go-task/slim-sprig v0.0.0-20230315185526-52ccab3ef572
go: downloading github.com/segmentio/asm v1.2.0
go: downloading github.com/kr/text v0.2.0
go: downloading github.com/rogpeppe/go-internal v1.10.0
go: downloading github.com/nxadm/tail v1.4.8
go: downloading github.com/golang/glog v1.1.2
go: downloading github.com/google/pprof v0.0.0-20230228050547-1710fef4ab10
go: downloading go.step.sm/crypto v0.16.2
go: downloading github.com/go-faster/yaml v0.4.6
go: downloading github.com/ghodss/yaml v1.0.0
go: downloading go.uber.org/multierr v1.11.0
go: downloading go.uber.org/zap v1.26.0
go: downloading github.com/dlclark/regexp2 v1.10.0
go: downloading gopkg.in/tomb.v1 v1.0.0-20141024135613-dd632973f1e7
go: downloading golang.org/x/mod v0.13.0
go: downloading github.com/fsnotify/fsnotify v1.5.4
go: downloading gopkg.in/yaml.v2 v2.4.0
go: downloading go.uber.org/goleak v1.2.1
go: downloading filippo.io/edwards25519 v1.0.0-rc.1
go: finding module for package code.cloudfoundry.org/app-autoscaler/src/autoscaler/fakes
go: finding module for package code.cloudfoundry.org/app-autoscaler/src/autoscaler/helpers/apis/scalinghistory
go: downloading code.cloudfoundry.org/app-autoscaler v0.0.0-20211201103113-81a4f0cac637
code.cloudfoundry.org/app-autoscaler/src/autoscaler/api/publicapiserver imports
	code.cloudfoundry.org/app-autoscaler/src/autoscaler/helpers/apis/scalinghistory: module code.cloudfoundry.org/app-autoscaler@latest found (v0.0.0-20211201103113-81a4f0cac637), but does not contain package code.cloudfoundry.org/app-autoscaler/src/autoscaler/helpers/apis/scalinghistory
code.cloudfoundry.org/app-autoscaler/src/autoscaler/api/broker tested by
	code.cloudfoundry.org/app-autoscaler/src/autoscaler/api/broker.test imports
	code.cloudfoundry.org/app-autoscaler/src/autoscaler/fakes: module code.cloudfoundry.org/app-autoscaler@latest found (v0.0.0-20211201103113-81a4f0cac637), but does not contain package code.cloudfoundry.org/app-autoscaler/src/autoscaler/fakes

it is the ./scripts/update, https://github.com/cloudfoundry/app-autoscaler-release/blob/main/scripts/update instruction which is failing, before starting the bosh create-release command.
So, if I understood your suggestion, I should insert the command make generate-fakes generate-openapi-generated-clients-and-servers go-mod-tidy go-mod-vendor db scheduler before running ./scripts/update.

Is this correct?

[silvestre]

Hi @fdalfons ,
it looks like with cf07807 we replaced in our release pipeline scripts/update with make target invocations but missed to remove scripts/update which is as far as I can see no longer used anywhere. (I will open a PR to remove it, so that it doesn't cause further confusion).

Accordingly can you please try replacing the scripts/update call with make generate-fakes generate-openapi-generated-clients-and-servers go-mod-tidy go-mod-vendor db scheduler?

[fdalfons]

Hi @silvestre,

it worked, thanks for your assistance.

[silvestre]

You're welcome!