Comments (6)
Hey @jandubois, I am from the eirini team and am working on the story now. I am happy to report that the PR is working as expected. Thanks for the fix!
from fissile.
cc @cloudfoundry-incubator/eirini
from fissile.
Any news on this?
from fissile.
@gdankov: I've created a PR so that imagePullSecrets
aren't generated when the username is empty:
{{- if ne .Values.kube.registry.username "" }}
imagePullSecrets:
- name: "registry-credentials"
{{- end }}
The same condition is also put around the whole contents of registry-secret.yaml
.
You can can point the SCF build to the checks/fissile-7.0.0+297.g2485f273.linux-amd64.tgz
CI build by changing the fissile flavour and version at https://github.com/SUSE/scf/blob/develop/bin/common/versions.sh#L12-L13.
Please let us know if this fixes the problem for you!
from fissile.
Please let us know if this fixes the problem for you!
There merging of this PR is currently blocked on getting confirmation that the change fixes the issue; so please report back as soon as you know!
from fissile.
Any news on this?
from fissile.
Related Issues (20)
- [question] do you have a plan to support the Cloud Foundry releases for this? HOT 1
- [WIP] Dockerfile for Fissile build
- Unauthorized HOT 6
- fissile does not build HOT 1
- Walkthrough manifests are unusable HOT 3
- New compilation cache code creates broken archives
- Update dependencies once mholt/archiver#92 has landed HOT 1
- Pod runtime information is in a non-sensical spot HOT 2
- add pre-built binaries to github releases? HOT 1
- `fissile diff` only works with already unpacked release directories and not with URLs
- Race condition for active/passive pods when no leader is available HOT 4
- Example doc for build in configuration.md is wrong (create-release.sh not found) HOT 1
- Role manifest shared volume validation bug HOT 1
- Services generated by fissile make Istio malfunction HOT 2
- Move to Go Modules HOT 1
- Generated K8s resources will not be supported in K8s 1.16
- docker run example for nats-release fails: cannot access '/usr/local/bin/create-release.sh': No such file or directory HOT 7
- Cut releases with release notes? HOT 3
- Why not create docker images from rev releases?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fissile.