Comments (9)
What do you mean?
https://github.com/cloudfoundry/vmc/tree/master/spec
https://github.com/cloudfoundry/vmc/blob/master/vmc.gemspec#L24
from vmc.
I'm sorry. I'm super blind. I saw only the line before. And that the vmc 0.3.23 gem doesn't have specs packaged in them.
from vmc.
Why isn't the gemspec and other root files also being bundled? That is, why are there any files not being bundled into the gems?
from vmc.
Will you accept a patch to move to the gemspec that bundle gem NAME
generates?
spec.files = `git ls-files`.split($/)
spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
spec.require_paths = ["lib"]
from vmc.
I'm intrigued, why would you want that stuff? We're moving to not package specs with the gem in general, because all it does it make the gem files bigger. These days it's easy enough to go find the gem source on github if you want to see how the sausage is made.
from vmc.
Just realised this repo is deprecated and its now cf repo.
Versioned gems are forever; repos change. For example, vmc => cf repo. I cannot easily find the specs & gemspec for the older vmc releases that work with CF v1. In part perhaps; and I'm not sure; but all the tags have been lost for the old gems.
Why does bundler's generated gemspec bundle every file if its not useful?
I don't think there are any large development-only assets in the vmc/cf gem? So just how big are we scared this gem will get?
from vmc.
Bundler's generated gemspec is probably a sane default because it can't know what you'll be doing with the structure of your project. I also don't like that loading the gemspec requires git
to be installed, and that it makes assumptions about your working directory (has to be same as the .gemspec).
In general gems should only have what they need to be used - I certainly wouldn't want vmc and all of its dependencies to be grabbing code that's irrelevant to its functioning. For example, spec assets would be a concern, as we're starting to expand CF's integration specs and it's starting to include dummy rails/sinatra apps, etc.
We've started using a deployment script that automatically tags the repository when gems are cut, so you should be able to use those in the future.
https://github.com/cloudfoundry/cf/tags - v0.6.0 is when we cut over to cf
and stopped caring about v1 APIs.
from vmc.
Also: VMC 0.3.x had no specs. So, there's that.
And CF does export some spec files, for example spec support libraries that its plugins can use to write their specs. But perhaps these should be extracted into a gem instead.
from vmc.
Ok, thanks guys.
from vmc.
Related Issues (20)
- Service names with whitespaces or strange chars HOT 2
- Dependency on rspec 1.3.2 in Rakefile should be specify. HOT 1
- VMC::Cli::Config.suggest_url works by side effect
- Become resilient to npm packages that install symlinks in .bin HOT 1
- rubyzip2 dependency is failing HOT 3
- Warning on install due to rubyzip2 being deprecated HOT 2
- new vmc manifests feature should support --runtime HOT 2
- add .vmcignore file for vmc push (and document current filters) HOT 7
- "unknown file type META-INF/maven/" when trying to upload war file HOT 7
- vmc targets returning an error when no auth token are defined HOT 1
- vmc register doesn't work if the cloud_controller doesn't use UAA HOT 5
- unable to bind serivce to app due to VMC error HOT 2
- Receive ruby error when trying to do a push --no-start HOT 13
- vmc push --no-start throws a ruby error HOT 2
- Broken set-env when value contains = signal HOT 1
- Deprecated? HOT 2
- Poor diagnostics when vmc is used against v2 CF instance HOT 5
- Rubygems.org 500 Error HOT 3
- Issue using bundle install on VMC gem HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vmc.