Comments (4)
fileResponse = new Response(`Success!`, { status: 200 });
This is hyper-suspect, I'm betting that normalizeHeaders
is assuming headers are always set, but isn't at all in this case. If you set headers to an empty object in the response init object, does it resolve it as a workaround?
from miniflare.
That value is never being fed to the cache. In the code above I do explicitly add headers using modifyHeaders
.
fileResponse = new Response(fileResponse.body, {
status: fileResponse.status,
statusText: fileResponse.statusText,
headers: processedHeaders
});
from miniflare.
Hello again! 👋 This issue here is that Miniflare's Cache
doesn't support using URL
objects as cache keys, so...
const url = new URL(req.url);
// ...
cache.put(url, new Response(...))
...isn't behaving properly. As per the spec (https://w3c.github.io/ServiceWorker/#cache-put) this should work though, so I'll fix this.
Is this caching working on Cloudflare by the way? I think as you're not setting any Cache-Control
headers, nothing will actually get cached, or did you trim those out for this example?
from miniflare.
Just released version 1.4.0
with this fix. Please let me know if you have any other issues or feedback. 😄
from miniflare.
Related Issues (20)
- Request: Always resolve source maps on Errors HOT 4
- Node 21 vitest-environment-miniflare compatibility HOT 1
- [Miniflare 3] Step debugging with multiple workers HOT 2
- Update undici dependency due to vulnerability HOT 1
- [Docs] Miniflare v2 docs removed? HOT 3
- How to migrate Jest unit tests to Miniflare V3? HOT 1
- Support for typescript. HOT 1
- Is is it possible to collect coverage with vitest-environment-miniflare? HOT 2
- Increase better-sqlite3 compatibility HOT 1
- Uncaught error when initializing two top level WASM modules
- Multiple nodejs_compat packages missing (`crypto`, `path`, etc) HOT 4
- Fix CVE-2024-24758 HOT 3
- Type confusion HOT 1
- @miniflare/shared should not depend on @types/better-sqlite3 HOT 1
- Vitest bug: "Error: ENOENT: no such file or directory" HOT 2
- Workers: Error when an undefined value is exported in dev environment
- Type incompatibility issue between miniflare and workers-types HOT 4
- BUG: cannot install this library in node 22, please update better-sqlite3 HOT 1
- MiniflareCoreError [ERR_RUNTIME_FAILURE]: The Workers runtime failed to start. HOT 7
- How to test with `nodejs_compat` workers?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from miniflare.