Comments (2)
Thanks for the report @technomancy, clojure-lsp has a general waterfall settings checking from project to home dir, but maybe we could check only the home one for this one somehow.
Also we don't have ATM a way to fallback for classpath lookup commands, we would need to support that, unless we think in a way the fallback is not needed.
from clojure-lsp.
Honestly I don't know that I have enough context to say what the right thing to do here is. Thinking about this more, there are legitimate and safe reasons to want to override the classpath command on a per-project basis; maybe clojure-lsp
guesses wrong and you want the project to set an override to a different command, but the other command is still safe.
I've never used deps.edn
or any of the other classpath calculation tools. Are they safe to run on untrusted projects? (Disabling *read-eval*
etc?) I see that there is also a :java-command
config setting which could trivially be overridden by an untrusted project to run arbitrary code.
It's clear to me that my original suggestion of "avoid lein classpath and use lein static-classpath instead" is insufficient for the purposes of achieving "opening an untrusted file shouldn't pwn your system"; it's a small part of the puzzle, but there's a lot more to it. From my perspective, I want to make sure that static-classpath
is available for people who want to do the work of making the tooling safe, but I don't think I can be the one to do that work, and I don't know how much of a priority it is for the maintainers of clojure-lsp
.
from clojure-lsp.
Related Issues (20)
- False positive: Unused public var 'clojure-sample.component-example/CircuitBreaker'
- Exception on workspace/didChangeConfiguration messages HOT 3
- Add keyword definitions (reg-...) to :clojure/workspace/projectTree/nodes HOT 7
- Adding require command fails for requires without alias HOT 1
- Rename namespace alias with API / CLI HOT 3
- Alias code action "Add require ... x 1" instead of real count HOT 1
- Renaming of function, when done twice, loses track of change HOT 3
- Creating a new `.clj` file in eglot takes a long time HOT 1
- Enable "find references" for quoted qualified symbols HOT 3
- rename ns picks wrong source-path
- Add "Replace full qualified ns with alias" feature
- Allow reusing of another functions `:doc` and `:arglists` HOT 5
- Display fully-qualified function name on textDocument/signatureHelp
- Creating a new Clojure file with Γ¦/ΓΈ/Γ₯ in the filename breaks `workspace/willRenameFiles` HOT 1
- Allow disabling external keyword exclusions
- Allow a null `rootUri` during initialization instead of crashing
- Clojure LSP incorrectly marks `[\!\@]` as an error `<form> expected, got '\!\@'`
- LSP Organize imports code action not working with a `#_` comment
- Add inline-function to commands
- Publish checksums for nightly builds
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from clojure-lsp.