Coder Social home page Coder Social logo

Comments (2)

rrudakov avatar rrudakov commented on June 9, 2024

Some major modes in emacs has workarounds for different versions of grammars (for example https://git.savannah.gnu.org/cgit/emacs.git/tree/lisp/progmodes/typescript-ts-mode.el?h=emacs-29#n157). Would something like this work for clojure-ts-mode?

from clojure-ts-mode.

dannyfreeman avatar dannyfreeman commented on June 9, 2024

Indeed, I've submitted a couple bug fixes to Emacs for js-ts-mode where those version workarounds didn't work properly.

When tree-sitter-clojure or another grammar this mode depends on is inevitably updated we will have to use workarounds like that. In my experience those are very cumbersome to write and test. Mostly because there is no way to tell what version of a grammar is loaded.

Depending on the nature of a future grammar update, that may mean users of the latest grammar get more features than those using an older grammar. If a user wonders why they aren't seeing some new fancy highlighting then the functionality described in this issue would help them figure out why.

tree-sitter-clojure is pretty stable though, and the only other grammar we depend on is a markdown grammar, and in that we only query for 1 type of node. Because there isn't a great need for this this feature at the moment, it is low on my priority list.

from clojure-ts-mode.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.