Remove :arglists key, in favor of :arglists-str about cider-nrepl

[bbatsov]

Btw, maybe we should get @cemerick involved in the discussion as well.

Personally, I don't have a problem with returning the arglists as a string. We use it as a string in the client, anyways...

[tpope]

Yes, I have been using arglists-str only, so I don't have stake in the structured representation.

[cemerick]

I'm not really clear on the context/problem here (just due to my lack of familiarity w/ elisp, cider itself, etc), but yes, bencode keys must be (byte) strings. This is ensured here in nREPL itself:

https://github.com/clojure/tools.nrepl/blob/master/src/main/clojure/clojure/tools/nrepl/transport.clj#L28

Are you needing to bencode manually/directly at all, rather than just using transport/send?

[gtrak]

Nah, we're relying on transport/send, this just means we can't expect
to send arbitrary edn data over, (that would've been nice :-)

On Friday, May 16, 2014, Chas Emerick [email protected] wrote:

I'm not really clear on the context/problem here (just due to my lack of
familiarity w/ elisp, cider itself, etc), but yes, bencode keys must be
(byte) strings. This is ensured here in nREPL itself:

https://github.com/clojure/tools.nrepl/blob/master/src/main/clojure/clojure/tools/nrepl/transport.clj#L28

Are you needing to bencode manually/directly at all, rather than just
using transport/send?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/61#issuecomment-43381208
.

[cemerick]

Yeah, OK. There's technically no reason why an EDN transport couldn't be assembled, but the advantages vs. tool incompatibility probably isn't worth it. Kind of surprised someone hasn't implemented it yet regardless.

[bbatsov]

@gtrak I've updated the Elisp code to use arglists-str.