State changes not picked up about citrus

[gmp26]

Just tested by patching the example counter with:

[:button {:on-click #(doseq [i (range 10)] (citrus/dispatch! r :counter :inc))} "+10"]

and yes, the counter only increments by 1.

Whereas:

[:button {:on-click #(doseq [i (range 10)] (citrus/dispatch-sync! r :counter :inc))} "+10"]

increments by 10.

[gmp26]

OK, I'm now of the opinion this is the behaviour we should expect for the asynchronous case as forcing a wait on state handling before enqueuing another event would be equivalent to synchronous behaviour.

[roman01la]

This is definitely a bug. Async events are batched and executed asynchronously, but this should not change the behavior. I’ll look into this.

[mjmeintjes]

Here's what I'm using for now:

(r/dispatch! [this cname event args]
    (queue-effects!
     queue
     [cname #((get controllers cname) event args (get % cname))])

    (schedule-update!
     batched-updates
     scheduled?
     (fn []
       (let [effects (into [] @queue)]
         (clear-queue! queue)
         (let [[curr-state handlers]
               (reduce
                (fn [[curr-state handlers] [cname ctrl]]
                  (let [effects (ctrl curr-state)]
                    [(if-let [s (:state effects)]
                       (assoc curr-state cname s)
                       curr-state)
                     (concat handlers (->> (dissoc effects :state)
                                           (filter (comp seq second))))]))
                [@state []]
                effects)]
           (reset! state curr-state)
           (m/doseq [[id effect] handlers]
             (when-let [handler (get effect-handlers id)]
               (handler this cname effect))))))))

I can make a PR if you are interested.

[gmp26]

@roman01la - yes - much easier to think about that way! Code from @mjmeintjes fixes my test case.

[roman01la]

Just published a fix in 3.0.1. @mjmeintjes thank you for that code sample