key events not accepted after setting the shortcut about keyholder

[DivineDominion]

Turns out that makeFirstResponder is not the problem. In the example app, you can reproduce this e.g. by holding shift ⇧ and type a letter, continue holding shift, and type another letter. The second letter will not be accepted.

The problem is that flagsChanged(_:) will not be called when the user releases the modifier key, only when pressing it. So we have to reset inputModifiers somewhere.

But resetting it with inputModifiers = NSEvent.ModifierFlags(rawValue: 0) in endRecording is not a good place. I'll experiment with calling flagsChanged from keyUp instead, and resetting when key view status is lost.

[DivineDominion]

Weirdly, hitting space is configured to always begin recording in performKeyEquivalent(with:). Why is that so?

        // ...
        } else if Int(theEvent.keyCode) == kVK_Space {
            return beginRecording()
        }
        // ...

This allows one to reenable recording:

1. hold shift (and never release)
2. hit a key, e.g. "F" to change the shortcut
3. hit another key, e.g. "D" and notice the beep
4. hit space
5. hit another key again to change the shortcut

I think this is not intentional?

[Econa77]

Closed by #11 #47