Coder Social home page Coder Social logo

add wet day frequency correction about dodola HOT 3 CLOSED

dgergel avatar dgergel commented on September 1, 2024
add wet day frequency correction

from dodola.

Comments (3)

brews avatar brews commented on September 1, 2024

@dgergel Hmmm. Thinking about making the interface natural... I feel like you're describing it as an option to bias-correction. How about start by setting it as a boolean flag to biascorrect:

dodola biascorrect {insert usual options here} --wetday-correction

This feels pretty natural to me.

It would be an option to the bias correction service, but you can implement it in the core however you'd need, of course.

from dodola.

dgergel avatar dgergel commented on September 1, 2024

It needs to be more than an option to bias correction because it will also come into the pipeline after downscaling (the post-processing step is after both bias correction and downscaling). So, I'm fine with the above syntax, but we will also need something along the lines of:

dodola wetday_correction <input zarr store> <output zarr store> --post-process 

So, seems like we could have pre-process and post-process flags to the wetday_correction service, and add it as a boolean flag to the bias correction service? @brews how does that sound?

from dodola.

brews avatar brews commented on September 1, 2024

@dgergel @dgergel Hmm. So then the post-processing step is identical for downscaling?

What if we add a similar flag to dodola downscale, rather than making it an explicit, new step:

dodola downscale <blah blah blah> --wetday-correction

The wet-correction in downscaling and bias correction might share the same functions/classes in dodola/core.py (which we can unit test)?

Does this solve your issue or it might be that there is something critical that I'm totally missing?

from dodola.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.