Comments (3)
@dgergel Hmmm. Thinking about making the interface natural... I feel like you're describing it as an option to bias-correction. How about start by setting it as a boolean flag to biascorrect
:
dodola biascorrect {insert usual options here} --wetday-correction
This feels pretty natural to me.
It would be an option to the bias correction service, but you can implement it in the core however you'd need, of course.
from dodola.
It needs to be more than an option to bias correction because it will also come into the pipeline after downscaling (the post-processing step is after both bias correction and downscaling). So, I'm fine with the above syntax, but we will also need something along the lines of:
dodola wetday_correction <input zarr store> <output zarr store> --post-process
So, seems like we could have pre-process and post-process flags to the wetday_correction service, and add it as a boolean flag to the bias correction service? @brews how does that sound?
from dodola.
@dgergel @dgergel Hmm. So then the post-processing step is identical for downscaling?
What if we add a similar flag to dodola downscale
, rather than making it an explicit, new step:
dodola downscale <blah blah blah> --wetday-correction
The wet-correction in downscaling and bias correction might share the same functions/classes in dodola/core.py
(which we can unit test)?
Does this solve your issue or it might be that there is something critical that I'm totally missing?
from dodola.
Related Issues (20)
- add AIQPD downscaling method adjust test HOT 1
- add multiplicative test for AIQPD method HOT 1
- update QDM in AIQPD test to use core functions HOT 1
- Pin ClimateImpactLab/xclim to single commit hash or tag HOT 1
- "regrid" drops dataset attributes HOT 8
- update precip units in cmip6 cleanup to be pint-compatible HOT 9
- dodola validate-dataset reads in entire zarr store? HOT 1
- update all analog-downscaling code names to new method name, QPLAD HOT 1
- update time check in dodola validate HOT 3
- Remove excess unit conversion logging to INFO from dodola.service HOT 4
- xclim_convert_360day_calendar_interpolate does not support data chunked across time
- wet-day frequency correction uses only one value for each 'dry' data point
- correct-wetday-frequency casts all output to float64 HOT 1
- dodola.services.get_attrs() is missing logging.
- Test that `dodola.services.validate` actually fails bad data
- Validation checks should throw new ValidationFailed-like, not AssertionError HOT 1
- Clean up container build, swap to mambaorg/micromamba
- Add label for code source to container images HOT 1
- Unit tests are very very slow
- CI is pretty inefficient building, testing containers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dodola.