Coder Social home page Coder Social logo

Comments (2)

samcoe avatar samcoe commented on June 27, 2024

@tjgurwara99 Thanks for the feature request. This type of feature has come up a couple times in the cli/cli repo, mainly around being able to support multiple accounts GitHub accounts and switching them based on the current local repository. I think gh itself should be vary wary of creating its own per repository config files as that greatly complicates the reading and writing of gh configurations, but if an extension wants to create its own configuration files I think we can support that.

Right now the limiting factor for this feature is the hardcoded locations for reading and writing configuration files using the generalConfigFile() and hostsConfigFile() functions as you mentioned. I think if we introduced two new functions to the config package ReadFromPath(path string) (*Config, error) and WriteToPath(path string, c *Config) error that would allow extensions to read/write/manipulate yaml files and it would be on the extensions to manage their own configuration files as they see fit.

Note that the config package only has infrastructure for working with yaml files so I don't think we will want to support any other formats.

What do you think of this approach?

from go-gh.

tjgurwara99 avatar tjgurwara99 commented on June 27, 2024

I think if we introduced two new functions to the config package ReadFromPath(path string) (*Config, error) and WriteToPath(path string, c *Config) error that would allow extensions to read/write/manipulate yaml files and it would be on the extensions to manage their own configuration files as they see fit.

This sounds good to me. I think its a good approach as this would provide the extension owner the freedom to set their configuration however they see fit.

from go-gh.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.