[Interface] Hide "attempt to hack this safe" pop-up when player doesn't have a hacking tool about cataclysm-dda

[DragonWizard23]

Hey PatrikLundell, thanks for the reply!

I'm not too keen on the 'e' interaction only doing anything at all if you happen to have the tool it requires available, as this means you can easily get the impression that something can't be interacted with, when in reality you don't happen to carry the correct tool.

I think we are in agreement. I don't think I was very clear, but I do want the player to be able to examine the safe regardless of whether or not the player has a hacking tool with enough charges. I'm thinking along the same line as how the player can examine a locked door or gate without picking/prying tools. (Those create log messages instead of pop-ups.)

I'd rather have a feedback saying you don't have a a suitable tool, or that your tool doesn't have enough charges (without a popup requiring acknowledgement).

Yep, this is what I had in mind. When the character examines a safe without a hacking tool with enough charges, there should still be the log message: "You don't have a hacking tool with enough charges!" However, I'm suggesting that we remove the confirmation pop-up, because it isn't necessary. If the player doesn't have the requirements to hack the safe, the pop-up will always end with the same result (not attempting to hack the safe). By removing the pop-up but keeping the log message, the behavior will be consistent with other locked things (gates, doors, etc).

[PatrikLundell]

I disagree slightly.

I'm not too keen on the 'e' interaction only doing anything at all if you happen to have the tool it requires available, as this means you can easily get the impression that something can't be interacted with, when in reality you don't happen to carry the correct tool.
I'd rather have a feedback saying you don't have a a suitable tool, or that your tool doesn't have enough charges (without a popup requiring acknowledgement).
That has the disadvantage that you may have to select what to interact with when there are some things in range you don't have the tools for.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.