Login attempt rerendering the login.js page ? about pup

[cleverbeagle]

Ah, I see what you're getting at. I'll take a look :)

[aferreol]

Just looked at the code, It's caused because the prop loggingIn is changing to true during login attempt, making the public component to return a simple <div /> because of this condition in the public component :

if (loggingIn) return <div />;

After Meteor.loggingIn() is going back to false, (so is the logginIn prop), the public component will return the login component, which has to re-render because it's been replaced by a simple div during the loggin attempt.

[cleverbeagle]

Not sure I understand, can you provide a video of what's happening? Technically speaking, no, the page shouldn't be blinking. If a login attempt fails, you should see a message and remain on the login page until you can successfully login.

[joserocha3]

I noticed this as well. It appears that the form submit causes the Public component to recreate the Login component. You do get the Bert alert, but the page completely re-renders which resets the form fields.

[aferreol]

@cleverbeagle You do remain on the login page, but react will render the component login another time, loosing any information in the inputs, making the login form disappear and appear again. (which means for example if you had to scroll to login, you will be back at the top of the page)

http://imgur.com/a/83EY5

here is a small gif of what's happening. The login wasn't re-rendering in base, that's why I asked the question :)

EDIT : Exactly like @joserocha3 said !