[Classic: San Andreas] - Events.cleo Plugin Conflict with VehFuncs about cleo-redux

Hey @x87 & @JuniorDjjr

I just test VehFuncs Build (Mention in Above) & Its Works Fine with Events.cleo (I means work with Complete CLEO Redux)

[JuniorDjjr]

So I think it's ok, I'll do another thing and release it for public.

A note about the crash I mentioned in FxsFuncs, for those who are curious, this only happens if I set the initGameEvent (0x748CFB) (plugin-sdk) in VehFuncs, then a FxsFuncs patch receives wrong values, it was fixed when changing to another event, I don't understand what could have happened.

[JuniorDjjr]

Send some crash dump (CrashInfo, modloader.log)

Log Files: logs.zip

Installed:
Essential Pack (From Mixmods)
CLEO Redux (From Github)
VehFuncs (From Mixmods)

[JuniorDjjr]

IPL related... this looks weird.

@JuniorDjjr main thing

Game works normally with Cleo Redux & VehFuncs
Only Problem with Events.cleo Plugin

Events.cleo In + VehFuncs Out = Game Works
VehFuncs In + Events.cleo Out = Game Works
Events.cleo & VehFuncs (Both In) = Game Not Works

[JuniorDjjr]

And VehFuncs have no relation to events related to IPL, map, unload etc. It's probably some very specific problem, I have nothing in mind.

[x87]

Events.cleo hooks two game functions: CWorld::Add and CWorld::Remove. Does VehFuncs call or hook those functions directly or indirectly by spawning something in the game?

[x87]

I see that it makes some code change here:

MakeJMP(0x00563281, Patches::CheckCrashWorldRemove, true);

but the actual start of the CWorld::Remove is at 00563280, so it probably partially deletes another detour set by CLEO if it was run earlier (it also makes a new jump instruction there) making the code invalid.

@JuniorDjjr do you think if changing the patch address from 0x00563281 to 0x00563280 could help? Or just remove this patch altogether?

[JuniorDjjr]

I don't remember why I use 1 byte ahead, but I tried to recompile VehFuncs using VS 2022 and now FxsFuncs (not VehFuncs) crashes on injector inline call for 0x5C235B. I don't know why, even without any changes this happens, I also tried to recompile FxsFuncs in VS 2022.

[x87]

I don't see anything useful in 0x5C235B

.text:005C2356 1C4 68 00 01 00 00                          push    100h            ; int
.text:005C235B 1C8 8D 94 24 C8 00 00 00                    lea     edx, [esp+1C8h+lineBuf]
.text:005C2362 1C8 52                                      push    edx             ; char *
.text:005C2363 1CC 55                                      push    ebp             ; FILE *
.text:005C2364 1D0 E8 E7 8E EE FF                          call    ReadLine(int,char *,int)

maybe you mean 005C2364 ?

[JuniorDjjr]

I think the problem existed in my game but I didn't have VehFuncs.asi installed, it doesn't seem to have anything to do recompile, but it's still a very strange problem that I need to check someday (I'm pretty out of modding). Happens with CFileMgr::ReadLine inside FxsFuncs in MakeInline<0x5C235B when VehFuncs is installed, but I pretty much always had both installed in my game without issues.

Here is the VehFuncs recompiled patching 0x00563280 instead, and push esi.
https://drive.google.com/file/d/1JzurRk4PWwGpp1Q6gSXpx235n2vDP81y/view?usp=sharing
It works in my game (without using FxsFuncs for some reason), but not tested with CLEO Redux.

[x87]

@1234nir can you check that build?

[x87]

closing as resolved in VehFuncs 2.4
https://www.mixmods.com.br/2022/02/sa-vehfuncs/