Make the dependence on last.fm optional about clementine

[Clementine-Issue-Importer]

From [email protected] on March 01, 2010 23:35:36

I think is may be Enhancement.

[Clementine-Issue-Importer]

From john.maguire on March 02, 2010 10:41:30

Is there any particular reason for this request? What difference would it make?

Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low OpSys-All

[Clementine-Issue-Importer]

From theangeltabris on March 02, 2010 21:30:25

Not all the countries can "play for free" from LastFM, so it's not required.

I think that's a reason.

[Clementine-Issue-Importer]

From sterkrig on March 23, 2010 02:23:05

As for me, the main reason is ruby requirement. Of course, that's more or less question to liblastfm dev, but
nevertheless — if I want to build clementine, I need to install ruby (for liblastfm) and several Gnome libraries
(for libnotify). I don't demand anything, don't get me wrong, but optional dependencies are always better than
strict ones. To be honest, I didn't even compile Clementine on my Gentoo because of 12 packages it needs (I
haven't counted even boost, though I haven't it installed on my workstation). Even monstrous Amarok2
requires less.

[Clementine-Issue-Importer]

From john.maguire on March 23, 2010 04:50:20

Amarok 2 requires MySql so I still think we win there ;-)

liblastfm is pretty small, libnotify is optional already and you don't actually need
the boost libraries, only the headers, Gentoo doesn't make that easy IIRC. Someone
should be able to add a USE flag for libnotify pretty easily.

[Clementine-Issue-Importer]

From sterkrig on March 23, 2010 08:31:21

libnotify is optional already
That's very good indeed.

liblastfm is pretty small
Yes, it is. But it does require Ruby to be built from source, you see. If it was cmake-based, it would not be a
problem (at least for me, I'm not sure there's no cmake-haters around).

I'm not saying "do as I command you", but for me it is the problem and reason not to try Clementine, and I
have already heard several similar complaints from other users. So probably you'll make a note of this request.

[Clementine-Issue-Importer]

From davidsansome on March 23, 2010 09:53:47

I have actually been wanting to do something about the liblastfm dependency - it's a
pain to build on windows and mac as well.

I think the solution might be to bring it into Clementine's source tree in the
3rdparty directory, and hack it to build with cmake.

[Clementine-Issue-Importer]

From m.gysel on March 28, 2010 10:35:45

to add liblastfm into Clementine's source tree is not the solution, as

1. not everyone needs it (is there a good reason not to do so?)
2. do not bundle 3rd party libraries with a application, try to bring your changes upstream.
   maybe you should also read http://blog.flameeyes.eu/2009/01/02/bundling-libraries-for- despair-and-insecurity
   so please make it optional!!

[Clementine-Issue-Importer]

From john.maguire on March 28, 2010 11:26:26

Yeah, I don't want to import it into our tree either. We can make it optional, it's
just quite a bit of work for no bug fix or feature. Patches welcome ;-)

[Clementine-Issue-Importer]

From nigels.com on April 06, 2010 21:32:30

Seems that there is no LastFM .deb for Ubuntu Jaunty (9.04), so I'm out of luck
deploying Clementine on that particular machine, without compiling it from source,
and so on, and so on.

On the other hand, it rocks to have this on OSX, I'm so happy to ditch iTunes!

[Clementine-Issue-Importer]

From kadaimx on April 06, 2010 22:03:08

There is no last.fm in deb format for ubuntu?
I have myself that library installed, but I remember to have just installed the
development library (liblastfm-dev)

In any case, try then with liblastfm0 (yes, with that zero at the end) I happened to
found that I had that one installed and that is available on repos.

[Clementine-Issue-Importer]

From nigels.com on April 07, 2010 08:39:21

It is available for Jaunty in the backports repository: http://packages.ubuntu.com/jaunty-backports/i386/liblastfm-dev/download And now Clementine is building... yay!

[Clementine-Issue-Importer]

From nigels.com on April 07, 2010 11:46:36

Bah! Taglib on Jaunty seems to old for Clementine...

[ 53%] Building CXX object src/CMakeFiles/clementine_lib.dir/song.cpp.o
/home/fionas/Downloads/clementine-0.2/src/song.cpp:30:28: error: taglib/asffile.h: No
such file or directory
/home/fionas/Downloads/clementine-0.2/src/song.cpp:31:28: error: taglib/mp4file.h: No
such file or directory
/home/fionas/Downloads/clementine-0.2/src/song.cpp:33:29: error: taglib/aifffile.h:
No such file or directory
/home/fionas/Downloads/clementine-0.2/src/song.cpp:34:28: error: taglib/wavfile.h: No
such file or directory
/home/fionas/Downloads/clementine-0.2/src/song.cpp: In member function ‘void
Song::GuessFileType(TagLib::FileRef_)’:
/home/fionas/Downloads/clementine-0.2/src/song.cpp:266: error: expected type-specifier
/home/fionas/Downloads/clementine-0.2/src/song.cpp:266: error: expected >' /home/fionas/Downloads/clementine-0.2/src/song.cpp:266: error: expected('
/home/fionas/Downloads/clementine-0.2/src/song.cpp:266: error: ‘TagLib::RIFF’ has not
been declared
/home/fionas/Downloads/clementine-0.2/src/song.cpp:266: error: expected
primary-expression before ‘>’ token
/home/fionas/Downloads/clementine-0.2/src/song.cpp:267: error: expected )' before ‘d’ /home/fionas/Downloads/clementine-0.2/src/song.cpp:268: error: expected type-specifier /home/fionas/Downloads/clementine-0.2/src/song.cpp:268: error: expected>'
/home/fionas/Downloads/clementine-0.2/src/song.cpp:268: error: expected (' /home/fionas/Downloads/clementine-0.2/src/song.cpp:268: error: ‘TagLib::RIFF’ has not been declared /home/fionas/Downloads/clementine-0.2/src/song.cpp:268: error: expected primary-expression before ‘>’ token /home/fionas/Downloads/clementine-0.2/src/song.cpp:269: error: expected)' before ‘d’
make[2]: *_* [src/CMakeFiles/clementine_lib.dir/song.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/clementine_lib.dir/all] Error 2
make: *** [all] Error 2
fionas@nstewart-lt:/Downloads/clementine-0.2$ ls /usr/include/taglib
apefooter.h id3v2framefactory.h relativevolumeframe.h
trueaudiofile.h
apeitem.h id3v2frame.h speexfile.h
trueaudioproperties.h
apetag.h id3v2header.h speexproperties.h
tstring.h
attachedpictureframe.h id3v2synchdata.h tag.h
tstringlist.h
audioproperties.h id3v2tag.h taglib_export.h
uniquefileidentifierframe.h
commentsframe.h mpcfile.h taglib.h
unknownframe.h
fileref.h mpcproperties.h tbytevector.h
unsynchronizedlyricsframe.h
flacfile.h mpegfile.h tbytevectorlist.h
urllinkframe.h
flacproperties.h mpegheader.h textidentificationframe.h
vorbisfile.h
generalencapsulatedobjectframe.h mpegproperties.h tfile.h
vorbisproperties.h
id3v1genres.h oggfile.h tlist.h
wavpackfile.h
id3v1tag.h oggflacfile.h tlist.tcc
wavpackproperties.h
id3v2extendedheader.h oggpage.h tmap.h
xingheader.h
id3v2footer.h oggpageheader.h tmap.tcc
xiphcomment.h
fionas@nstewart-lt:/Downloads/clementine-0.2$

[Clementine-Issue-Importer]

From john.maguire on June 25, 2010 04:16:04

Issue 439 has been merged into this issue.

[Clementine-Issue-Importer]

From rick.g777 on October 02, 2010 10:38:38

Not all of us use Ubuntu, and unfortunately for me, liblastfm-dev is not available on the debian repos. So I can't even compile Clementine from source. Please remove that dependency. You can always add a package (plugin?) that integrates lastFM with Clementine.

[Clementine-Issue-Importer]

From volkov0aa on October 23, 2010 13:03:40

Here is the patch for svn revision 2189

Attachment: make-lastfm-optional.patch.gz

[Clementine-Issue-Importer]

From nitro322 on October 29, 2010 21:02:50

Has anyone tested volkov0aa's patch? Is there any reason why it can't/shouldn't be merged to resolve this issue?

[Clementine-Issue-Importer]

From volkov0aa on December 12, 2010 13:29:15

Patch for version 0.6 ( revision 2407 )

Attachment: make-lastfm-optional-2407.patch.gz

[Clementine-Issue-Importer]

From jobbara.artalmatlan on December 17, 2010 12:30:55

I was able to compile 0.6 without liblastfm dependency thanks to this patch.

[Clementine-Issue-Importer]

From davidsansome on December 18, 2010 09:28:12

This issue was closed by revision r2436 .

Status: Fixed

[Clementine-Issue-Importer]

From Nickollai on December 19, 2010 01:55:41

http://code.google.com/p/clementine-player/issues/detail?id=1138

[Clementine-Issue-Importer]

From Nickollai on December 19, 2010 12:37:51

Backported r2436 , r2448 , r2458 . Works fine for me.

Attachment: clementine-0.6-optional-liblastfm.patch

[Clementine-Issue-Importer]

From solomonov.v on December 26, 2010 01:12:35

After update of edit tag dialog clementine doesn't compile
(Gentoo ~x86? ebuild from gentoo multimedia overlay)

In file included from /var/tmp/portage/media-sound/clementine-9999/work/clementine-9999/src/ui/albumcoversearcher.h:21:0,
from /var/tmp/portage/media-sound/clementine-9999/work/clementine-9999/src/ui/edittagdialog.cpp:19:
/var/tmp/portage/media-sound/clementine-9999/work/clementine-9999/src/core/albumcoverfetcher.h:27:24: фатальная ошибка: lastfm/Album: No such file or directory
Compilation stopped.
make[2]: *** [src/CMakeFiles/clementine_lib.dir/ui/edittagdialog.cpp.o] Error 1
make[1]: *** [src/CMakeFiles/clementine_lib.dir/all] Error 2
make: *** [all] Error 2
emake failed

• ERROR: media-sound/clementine-9999 failed:
• Make failed!
• Call stack:

• ebuild.sh, line   56:  Called src_compile
  

• environment, line 3309: Called cmake-utils_src_compile
• environment, line 883: Called _execute_optionaly 'src_compile'
• environment, line 358: Called enable_cmake-utils_src_compile
• environment, line 1254: Called cmake-utils_src_make
• environment, line 902: Called die
• The specific snippet of code:

•       emake "$@" || die "Make failed!";
  

• If you need support, post the output of 'emerge --info =media-sound/clementine-9999',
• the complete build log and the output of 'emerge -pqv =media-sound/clementine-9999'.
• This ebuild is from an overlay named 'multimedia': '/var/lib/layman/multimedia/'
• The complete build log is located at '/var/tmp/portage/media-sound/clementine-9999/temp/build.log'.
• The ebuild environment file is located at '/var/tmp/portage/media-sound/clementine-9999/temp/environment'.
• S: '/var/tmp/portage/media-sound/clementine-9999/work/clementine-9999'

[Clementine-Issue-Importer]

From keirangtp on December 26, 2010 05:45:14

This should be fixed in the newest revisions.

[Clementine-Issue-Importer]

From solomonov.v on December 26, 2010 05:46:44

confirm, it works now.

[Clementine-Issue-Importer]

From keirangtp on December 26, 2010 09:11:33

Labels: Milestone-0.7