Coder Social home page Coder Social logo

Comments (7)

phmccarty avatar phmccarty commented on June 2, 2024 1

I don't really like the --back option name anymore since it does not describe the option meaning clearly.

--num-versions seems okay, but if you don't mind the verbosity, --previous-versions or --previous-version-count would be more clear to me.

from mixer-tools.

kevincwells avatar kevincwells commented on June 2, 2024 1

+1 I think --previous-versions is pretty good! Probably can infer the "count" from the fact it's an integer.

from mixer-tools.

matthewrsj avatar matthewrsj commented on June 2, 2024

What does the combination of --back K and --to N produce? Is it K back from N or K back from current and up to N? The first one seems more logical.

+1 for the proposal, I see this as necessary for the rewrite.

from mixer-tools.

cmarcelo avatar cmarcelo commented on June 2, 2024

Thanks for the review. Yes, it is the first one. I see how the original description is ambiguous, I'll improve that on the command help message.

from mixer-tools.

cmarcelo avatar cmarcelo commented on June 2, 2024

@tmarcu @kevincwells could one of you take a look at this before I proceed with it? :-)

from mixer-tools.

kevincwells avatar kevincwells commented on June 2, 2024

The overall idea makes sense to me -- +1 for obsoleting pack-maker.sh with mixer functionality.

As far as CLI, the meaning of --back -- and how it differs from --from -- definitely feels unclear at first. Maybe it could be named something a little more self-explanatory?

--back K means to build packs "for the previous K versions", and --back K --to N means "for the K versions leading up to N".... so maybe even something like --num-versions?

from mixer-tools.

cmarcelo avatar cmarcelo commented on June 2, 2024

OK! I was just reusing the name "back" from a previous PR. I'll incorporate one of those names instead.

from mixer-tools.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.