Coder Social home page Coder Social logo

Comments (3)

DigitalBrains1 avatar DigitalBrains1 commented on June 17, 2024 1

I think it's a bug if the starter project doesn't enable by default the extensions that we enable by default for compiling with clash. If I understand correctly, that would mean using clash directly accepts more or different stuff than using a starter project, which if anything is the reverse of what we want.

Also, I'm working on a PR where for use inside clash-compiler, we enable all extensions that are GHC2021 blessed. I think it would also be okay to enable them all by default for Clash designs as well.

Note your example is slightly flawed in that instead of HiddenClockResetEnable System you can actually write SystemClockResetEnable ;-). But if you replace all occurences of System by XilinxSystem then your point stands. Or any other domain for that matter.

from stack-templates.

lmbollen avatar lmbollen commented on June 17, 2024

I'm looking into the GHC2021 extensions, there are some we don't want such as StarIsType (we already have NoStarIsType enabled so that checks out) since using StarIsType breaks type level multiplication.

Furthermore using NamedWildCards causes errors in bittide without enabling PartialTypeSignatures. Specifically in combination with the circuit-notation plugin for circuits that are ignored.

I don't think just enabling the GHC2021 blessed extensions is a great idea and we should just see what encounter and selectively enable extensions based on that.

A quick search in bittide shows that we enable the following extensions commonly on a per module basis:

RecordWildCards
NamedFieldPuns
FlexibleContexts

(I'm personally guilty of introducing most of those)
I'd prefer just adding those.

from stack-templates.

lmbollen avatar lmbollen commented on June 17, 2024

Solved by #33

from stack-templates.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.