Update to DD 3.1 and TF 1.0 about terraform-datadog-monitors

[xp-1000]

Hello @koblas

About upgrading version for terraform and datadog provider, the current code base should be compatible.
Did you meet a specific problem with these versions ?

Currently, we don't have constraint for the provider version and that is true it would be better to add it.

Regarding the terraform version itself, we still set the 0.12.26 constraint which should be the oldest version compatible if I am not wrong. I think we should avoid to upgrade this minimum version without a good reason to allow users with old terraform versions to continue to use related modules.

[koblas]

The datadog provider 3.1 has changed threshold = { to monitor_threshold {. Also, it appears all of the lifecycle rules no longer work.

In Terraform 1.0 I noted in the common/filters the list(...) has been replaced with tolist([....])

Which basically means that if you upgrade to Terraform 1.0 this no longer works. Most packages would pin the 12.x version on the your 3.x release versions and then have a 4.x version which was Terraform 1.0 compatible.

[xp-1000]

@koblas https://github.com/claranet/terraform-datadog-monitors/releases/tag/v4.0.0 has been released with support for datadog provider v3 and it remains compatible with terraform 0.12

[koblas]

Thanks, but still a bit disappointed that you're not supporting Terraform 1.0.

[xp-1000]

It supports Terraform >= 0.12.31 including 1.0

[koblas]

Interesting, when I tried I got an error that said.

[xp-1000]

are you sure to use the v4.0.0 tag ? this list function has been removed in the related PR: https://github.com/claranet/terraform-datadog-monitors/pull/3/files#diff-c4f9a5a2a0532daa7985899e6b9e05df0246b2da7b84aedae790ff5405420c8aR15

[koblas]

I had missed that fix, thanks.