Coder Social home page Coder Social logo

Comments (3)

raymondbutcher avatar raymondbutcher commented on June 7, 2024

Hi,

Version 0.11.0 now supports custom build commands (example) which provides a solution to this problem, as you can run any pip commands you want in a custom build script.

But it would be pretty cool if it did this automatically. I wasn't previously aware of the manylinux platform options for pip.

https://github.com/pypa/manylinux
https://blog.zappa.io/posts/zappa-adds-support-for-manylinux-wheels
https://github.com/Miserlou/lambda-packages

Not sure when I'll have time to look into this though.

Cheers!

from terraform-aws-lambda.

thyming avatar thyming commented on June 7, 2024

would you accept a PR changing the platform default to manylinux, simply updating the flags passed to pip? i can't see how this could be less correct than the default right now, which is whatever platform you happen to run this module on.

from terraform-aws-lambda.

raymondbutcher avatar raymondbutcher commented on June 7, 2024

If it doesn't break anything then it seems like a good idea. I have never tried the platform option and don't know how it works. If there is no manylinux version of a package, does pip get the regular version instead (as though no platform was specified) or does it error because it couldn't find a version for the specified platform?

from terraform-aws-lambda.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.